GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] test: fix edge snapshot stack traces by codebytere · Pull Request #50237 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Oct 18, 2023

Copy link
Copy Markdown
Member

Backporting #49659 - it's affecting Electron in 18 and it'd help us a fair bit for this to land.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codebytere
codebytere requested review from GeoffreyBooth and MoLow October 18, 2023 08:32
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. v18.x labels Oct 18, 2023
@codebytere
codebytere force-pushed the backport-message-tests-18 branch from 6aeb5d7 to 57814ae Compare October 18, 2023 08:35
@codebytere codebytere mentioned this pull request Oct 18, 2023
test: fix Node.js color edge snapshot stack traces electron/electron#40250
Merged
4 tasks done
@GeoffreyBooth @codebytere
test: fix edge snapshot stack traces
fc6fe0f 
PR-URL: nodejs#49659
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@codebytere
codebytere force-pushed the backport-message-tests-18 branch from 57814ae to fc6fe0f Compare October 18, 2023 09:14
mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MoLow
MoLow approved these changes Oct 19, 2023
View reviewed changes
@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-ci PRs that need a full CI run. labels Nov 1, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55393/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55422/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 3, 2023
CI Reliability 2023-11-03 nodejs/reliability#706
Open
CI Reliability 2023-11-04 nodejs/reliability#707
Open
CI Reliability 2023-11-05 nodejs/reliability#708
Open
CI Reliability 2023-11-06 nodejs/reliability#709
Open
CI Reliability 2023-11-07 nodejs/reliability#710
Open
CI Reliability 2023-11-08 nodejs/reliability#711
Open
CI Reliability 2023-11-09 nodejs/reliability#712
Open
@targos

targos commented Nov 12, 2023

Copy link
Copy Markdown
Member

Thanks, the commit is now part of #50669
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@MoLow MoLow MoLow approved these changes
@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@codebytere @nodejs-github-bot @targos @mcollina @MoLow @GeoffreyBooth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.