GeezerVison

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

Shouldn't the version actually be 22.0.0?

Yes, I think we're missing a step for semver major releases in the release process to bump the major version on main.

Yeah, there are two bugs introduced in the file during the release of v21.0.0:

• major should be set to 22
• is_release should be set to 0

Something is wrong with the test, if I change it to 22.0.0:

❯ out/Release/node test/parallel/test-release-changelog.js
node:fs:453
    return binding.readFileUtf8(path, stringToFlags(options.flag));
                   ^

Error: ENOENT: no such file or directory, open '/Users/joyee/projects/node/doc/changelogs/CHANGELOG_V22.md'
    at Object.readFileSync (node:fs:453:20)
    at Object.<anonymous> (/Users/joyee/projects/node/test/parallel/test-release-changelog.js:42:24)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49 {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/joyee/projects/node/doc/changelogs/CHANGELOG_V22.md'
}

@joyeecheung you probably need to fix the IS_RELEASE macro at the same time. I think the bug slipped through because both mistakes happened.

Maybe we should just skip the test when it's not run on a release?

Oh, I see, it was supposed to skip, but NODE_VERSION_IS_RELEASE wasn't updated either.

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

CI: https://ci.nodejs.org/job/node-test-pull-request/55203/

CI: https://ci.nodejs.org/job/node-test-pull-request/55207/

Landed in 89a26b4

Sorry about that. As I've mentioned in the release slack channel, something might be missing in our major release guide. I've followed these strictly and something went wrong. I'll triple-check next time :)