GeezerVison is showing github.com — deps: update cjs-module-lexer to 1.4.0 by nodejs-github-bot · Pull Request #50458 · nodejs/node
Conversation
This is an automated update of cjs-module-lexer to 1.4.0.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@nodejs/loaders (I assume this is related to loaders), this update breaks the build
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
|
The build still looks broken.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
2024-09-01T01:43:13.3207023Z sccache clang++ -o /home/runner/work/node/node/out/Release/node_mksnapshot -pthread -rdynamic -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread -m64 -Wl,--start-group /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/src/node_snapshot_stub.o /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/tools/snapshot/node_mksnapshot.o /home/runner/work/node/node/out/Release/obj.target/libnode.a /home/runner/work/node/node/out/Release/obj.target/deps/histogram/libhistogram.a /home/runner/work/node/node/out/Release/obj.target/deps/sqlite/libsqlite.a /home/runner/work/node/node/out/Release/obj.target/deps/ada/libada.a /home/runner/work/node/node/out/Release/obj.target/deps/nbytes/libnbytes.a /home/runner/work/node/node/out/Release/obj.target/deps/simdjson/libsimdjson.a /home/runner/work/node/node/out/Release/obj.target/deps/simdutf/libsimdutf.a /home/runner/work/node/node/out/Release/obj.target/deps/ncrypto/libncrypto.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicui18n.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a /home/runner/work/node/node/out/Release/obj.target/deps/llhttp/libllhttp.a /home/runner/work/node/node/out/Release/obj.target/deps/cares/libcares.a /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a /home/runner/work/node/node/out/Release/obj.target/deps/uvwasi/libuvwasi.a /home/runner/work/node/node/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/runner/work/node/node/out/Release/obj.target/deps/brotli/libbrotli.a /home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libngtcp2.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libnghttp3.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicuucx.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicudata.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_turboshaft.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers_slow.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_inflate_chunk_simd.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_adler32_simd.a -latomic -ldl -lm -Wl,--end-group
2024-09-01T01:43:15.4362881Z LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj/gen; "/home/runner/work/node/node/out/Release/node_mksnapshot" "/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc"
2024-09-01T01:43:15.4369008Z LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj.target/deps/openssl; /opt/hostedtoolcache/Python/3.12.5/x64/bin/python3 tools/copyfile.py ./deps/openssl/nodejs-openssl.cnf "/home/runner/work/node/node/out/Release/obj.target/deps/openssl/openssl.cnf"
2024-09-01T01:43:15.5765865Z node:internal/deps/cjs-module-lexer/lexer:1444
2024-09-01T01:43:15.5766765Z
2024-09-01T01:43:15.5766788Z
2024-09-01T01:43:15.5767358Z
2024-09-01T01:43:15.5767696Z SyntaxError: Invalid or unexpected token
2024-09-01T01:43:15.5768229Z
2024-09-01T01:43:15.6577858Z make[2]: *** [node.target.mk:13: /home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc] Error 1
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I just cloned this branch, built and tested locally, and all seems to be working fine to me. Let me know if I can assist further.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Let's try to recreate from scratch
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @targos I'm building and testing on Windows so it seems like it's working fine on Windows. I can try a build on my work machine tomorrow if it helps.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
blocked
PRs that are blocked by other issues or PRs.
dependencies
PRs that add, update, or configure Node.js dependencies.
lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|