GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update c-ares to 1.25.0 by nodejs-github-bot · Pull Request #51208 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Dec 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.25.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label Dec 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/net
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@lpinca
lpinca force-pushed the actions/tools-update-c-ares branch from 476b81e to 245caf3 Compare December 19, 2023 10:16
nodejs-github-bot and others added 2 commits December 19, 2023 11:27
@nodejs-github-bot @lpinca
deps: update c-ares to 1.24.0
ff93e1a
@lpinca
fixup! deps: update c-ares to 1.24.0
25d357b
@lpinca
lpinca force-pushed the actions/tools-update-c-ares branch from 245caf3 to 25d357b Compare December 19, 2023 10:27
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 19, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56385/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56387/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Dec 19, 2023

Copy link
Copy Markdown
Member

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.

AIX doesn't have ifaddrs.h so those defines should be 0 on AIX.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 19, 2023

Copy link
Copy Markdown
Member

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the blocked PRs that are blocked by other issues or PRs. label Dec 19, 2023
@richardlau

richardlau commented Dec 19, 2023

Copy link
Copy Markdown
Member

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.

I think it makes sense to have those defines on platforms that have ifaddrs.h, just not on those that do not (e.g. AIX).
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Dec 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Dec 19, 2023

Copy link
Copy Markdown
Member

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.

Well we have a team to ask re. that -- ping @nodejs/platform-smartos.
lpinca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot changed the title deps: update c-ares to 1.24.0 deps: update c-ares to 1.25.0 Jan 5, 2024
@lpinca lpinca closed this Jan 5, 2024
@lpinca
lpinca deleted the actions/tools-update-c-ares branch January 5, 2024 14:42
@lpinca

lpinca commented Jan 5, 2024

Copy link
Copy Markdown
Member

Closed in favor of #51385.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca mentioned this pull request Jan 5, 2024
deps: update c-ares to 1.25.0 #51385
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

blocked PRs that are blocked by other issues or PRs. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nodejs-github-bot @lpinca @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.