GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] lib: enable global CustomEvent by default by himself65 · Pull Request #52270 · nodejs/node

Conversation

@himself65

@himself65 himself65 commented Mar 30, 2024

Copy link
Copy Markdown
Member

Backport of #43885

Fixes: #52269

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v18.x labels Mar 30, 2024
@himself65
himself65 force-pushed the himself65/20240529-pick branch from bc15550 to 6cf4503 Compare March 30, 2024 01:52
@daeyeon @himself65
lib: enable global CustomEvent by default
782a6e4 
Refs: nodejs#43885

Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: nodejs#44860
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@himself65
himself65 force-pushed the himself65/20240529-pick branch from 6cf4503 to 782a6e4 Compare March 30, 2024 01:58
@richardlau

richardlau commented Mar 30, 2024

Copy link
Copy Markdown
Member

Backport of #43885

#43885 is already in Node.js 18:

node/doc/changelogs/CHANGELOG_V18.md

Line 3535 in 7c02486

* **(SEMVER-MINOR)** expose CustomEvent on global with CLI flag (Daeyeon Jeong) [#43885](https://github.com/nodejs/node/pull/43885)

This instead appears to be backporting #44860 and that is semver-major.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina requested changes Mar 30, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry but adding new globals is semver-major, and we can't backport this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 and benjamingr reacted with thumbs up emoji himself65 reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 👀 1 reaction
@himself65 himself65 closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@himself65 @nodejs-github-bot @richardlau @mcollina @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.