GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: only generate specified build type ninja files by legendecas · Pull Request #53511 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Jun 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Release and Debug build configurations can not be shared, only
generate specified configuration in configure with the ninja
generator. This avoids generating invalid DEBUG ninja build files
when configure was not run with --debug.

Fixes: #53446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction
@legendecas
build: only generate specified build type files
95a97e1 
Release and Debug build configurations can not be shared, only
generate specified configuration in `configure`.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Jun 19, 2024
@legendecas

legendecas commented Jun 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Specifically, setting v8_enable_v8_checks in generated config.gypi to 1 and regenerate ninja files could fix the issue. Anyway, https://github.com/nodejs/node/blob/main/doc/contributing/building-node-with-ninja.md#producing-a-debug-build suggested that build with ./configure --ninja --debug && make.
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas requested a review from targos June 19, 2024 15:24
targos
targos approved these changes Jun 19, 2024
View reviewed changes
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 19, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 19, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59892/
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jun 19, 2024
View reviewed changes
anonrig
anonrig approved these changes Jun 20, 2024
View reviewed changes
joyeecheung
joyeecheung reviewed Jun 20, 2024
View reviewed changes
Comment thread configure.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59905/
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jun 20, 2024
View reviewed changes
joyeecheung
joyeecheung approved these changes Jun 20, 2024
View reviewed changes
@legendecas legendecas added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 22, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6cb940a into nodejs:main Jun 22, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

Landed in 6cb940a
ikhtearalamshawonmollah54321 reacted with thumbs up emoji ikhtearalamshawonmollah54321 reacted with hooray emoji ikhtearalamshawonmollah54321 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas deleted the build/ninja branch June 22, 2024 08:41
@targos

targos commented Jun 25, 2024

Copy link
Copy Markdown
Member

I should have tried it before approving. I'm not able to work with ninja and make after this change:

$ python3 configure.py --ninja --debug --node-builtin-modules-path=`pwd`
Warning! Loading builtin modules from disk is for development
INFO: configure completed successfully

$ make -j6
gmake: *** No rule to make target 'out/Release/build.ninja', needed by 'node'.  Stop.

$ make -j6 BUILDTYPE=Debug
gmake: *** No rule to make target 'out/Release/build.ninja', needed by 'node'.  Stop.
legendecas reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas mentioned this pull request Jun 25, 2024
Revert "build: only generate specified build type files" #53580
Merged
@legendecas

legendecas commented Jun 25, 2024

Copy link
Copy Markdown
Member Author

Yeah, make BUILDTYPE=Debug still builds in release mode so I think an alternative should be making the generated config.gypi works in both Release mode and Debug mode. Reverting since this is breaking existing work flow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 25, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node_mksnapshot debug build segfault

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@legendecas @nodejs-github-bot @targos @jasnell @lpinca @anonrig @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.