GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "deps: V8: cherry-pick 9ebca66a5740" by joyeecheung · Pull Request #53582 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Jun 25, 2024

Copy link
Copy Markdown
Member

Revert "deps: V8: cherry-pick 9ebca66a5740"

Reason for revert: broke test-snapshot-reproducible.js in
dynamically linked builds in the CI.

This reverts commit 4c730ae.

Refs: #53579

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
Revert "deps: V8: cherry-pick 9ebca66a5740"
65b4391 
Reason for revert: broke test-snapshot-reproducible.js in
dynamically linked builds in the CI.

This reverts commit 4c730ae.
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 25, 2024
@joyeecheung joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed build Issues and PRs related to Node.js builds or CI infrastructure. v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Jun 25, 2024
@github-actions

github-actions Bot commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.
bricss, sxa, and richardlau reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung mentioned this pull request Jun 25, 2024
test-snapshot-reproducible is failing in the main branch #53579
Closed
targos
targos approved these changes Jun 25, 2024
View reviewed changes
@targos targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 25, 2024
MoLow
MoLow approved these changes Jun 25, 2024
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gengjiawen
gengjiawen approved these changes Jun 25, 2024
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59960/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Jun 25, 2024
View reviewed changes

@legendecas legendecas left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the revert.

It's curious that the failure didn't occur in the PR CI: https://ci.nodejs.org/job/node-test-pull-request/59933/. It also runs the dynamically linked builds test: https://ci.nodejs.org/job/node-test-commit-linux-containered/44105/parameters/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau
richardlau approved these changes Jun 25, 2024
View reviewed changes
sxa
sxa approved these changes Jun 25, 2024
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 25, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jun 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/53582
✔  Done loading data for nodejs/node/pull/53582
----------------------------------- PR info ------------------------------------
Title      Revert "deps: V8: cherry-pick 9ebca66a5740" (#53582)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:revert-v8 -> nodejs:main
Labels     fast-track, dont-land-on-v22.x
Commits    1
 - Revert "deps: V8: cherry-pick 9ebca66a5740"
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/53582
Refs: https://github.com/nodejs/node/issues/53579
Reviewed-By: Michaël Zasso 
Reviewed-By: Moshe Atlow 
Reviewed-By: Jiawen Geng 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Richard Lau 
Reviewed-By: Stewart X Addison 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53582
Refs: https://github.com/nodejs/node/issues/53579
Reviewed-By: Michaël Zasso 
Reviewed-By: Moshe Atlow 
Reviewed-By: Jiawen Geng 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Richard Lau 
Reviewed-By: Stewart X Addison 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 25 Jun 2024 09:12:08 GMT
   ✔  Approvals: 6
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137991739
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137994149
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/53582#pullrequestreview-2137997217
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138346109
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138562753
   ✔  - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/53582#pullrequestreview-2138603737
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 40 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-06-25T11:27:14Z: https://ci.nodejs.org/job/node-test-pull-request/59933/.
- Querying data for job/node-test-pull-request/59933/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9666246956
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jun 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 8e33f20 into nodejs:main Jun 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 8e33f20
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas mentioned this pull request Jun 27, 2024
deps: V8: cherry-pick 9ebca66a5740 #53522
Merged
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@sxa sxa sxa approved these changes
@MoLow MoLow MoLow approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@joyeecheung @nodejs-github-bot @targos @gengjiawen @richardlau @sxa @MoLow @legendecas @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.