GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: c-ares: cherry-pick 64df444 by zcbenz · Pull Request #53706 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Backport c-ares/c-ares#802 which fixes compilation error when building for Windows with UNICODE defined.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@zcbenz
deps: c-ares: cherry-pick 64df444
b8aca0c 
Backport c-ares/c-ares#802 which fixes
compilation error when building for Windows with UNICODE defined.
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Jul 3, 2024
@zcbenz zcbenz added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. dependencies PRs that add, update, or configure Node.js dependencies. labels Jul 3, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60018/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Jul 4, 2024
View reviewed changes
StefanStojanovic
StefanStojanovic approved these changes Jul 4, 2024
View reviewed changes
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60059/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Jul 4, 2024

Copy link
Copy Markdown
Member

A new version of c-ares is already available. I think it is better to upgrade to that version instead of cherry picking this commit.
richardlau and RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz

zcbenz commented Jul 4, 2024

Copy link
Copy Markdown
Contributor Author

I’m good updating to the latest version instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented Jul 4, 2024

Copy link
Copy Markdown
Member

See #53722.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz zcbenz closed this Jul 5, 2024
@zcbenz
zcbenz deleted the fix-cares-win-build branch July 5, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zcbenz @nodejs-github-bot @lpinca @jasnell @StefanStojanovic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.