GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow nested data: imports with --experimental-network-imports by rsalim0 · Pull Request #53998 · nodejs/node

Conversation

@rsalim0

@rsalim0 rsalim0 commented Jul 22, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

This PR addresses issue [ISSUE_NUMBER] by allowing data: imports from other data: URLs when the --experimental-network-imports flag is used. This change modifies the condition in lib/internal/modules/esm/resolve.js to check for nested data: URLs correctly.
Additionally, a new test case has been added in test/parallel/test-esm-data-url-import.js to verify this behavior.

Fixes: #53992

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
rsalim0 added 2 commits July 23, 2024 00:24
@rsalim0
Updated resolve.js
cf3c0f3
@rsalim0
Update resolve.js
57aad40
@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
rsalim0 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jul 22, 2024
@legendecas

legendecas commented Jul 22, 2024

Copy link
Copy Markdown
Member

See also: #53822

rsalim0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell reviewed Jul 23, 2024
View reviewed changes
Comment thread lib/internal/modules/esm/resolve.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Jul 23, 2024
View reviewed changes
@rsalim0 @jasnell
Update lib/internal/modules/esm/resolve.js
5222d91
Co-authored-by: James M Snell <[email protected]>
RafaelGSS
RafaelGSS requested changes Jul 23, 2024
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSC reached a consensus to remove this feature. So, there's no reason to land this PR anymore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rsalim0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95

aduh95 commented Jul 24, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@RafaelGSS I disagree, I think it makes sense to land this to fix the behavior on release lines (also TSC consensus is not exactly relevant, it's up to Node.js collaborators, not the TSC, unless collaborators can't find consensus)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 mentioned this pull request Jul 24, 2024
lib,src: drop --experimental-network-imports #53822
Merged
@joyeecheung

joyeecheung commented Jul 25, 2024

Copy link
Copy Markdown
Member

I think it makes sense to land this to fix the behavior on release lines

I think in that case it should just be targeting release lines, instead of main?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung

joyeecheung commented Jul 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also, it seems the diff here isn't working, there are multiple relevant test failures, maybe there's some git error (OP mentioned a test case in test/parallel/test-esm-data-url-import.js, but it's not showing up in the diff), because the diff here clearly doesn't work (making use of an undefined variable).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95

aduh95 commented Jul 28, 2024

Copy link
Copy Markdown
Contributor

I tried checking out this branch and fixing the tests, unfortunately it's apparent that --experimental-network-imports is really broken, and since we're removing it, it seems not worth spending time fixing it.

Thanks for sending this PR, and sorry it won't work out this time!
Closing since the PR removing the feature from main has now landed.

rsalim0 reacted with thumbs up emoji rsalim0 reacted with confused emoji
All reactions
  • 👍 1 reaction
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@RafaelGSS RafaelGSS RafaelGSS requested changes
@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import data: from data: should be allowed

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@rsalim0 @nodejs-github-bot @legendecas @aduh95 @joyeecheung @jasnell @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.