GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Allow nested data: imports with --experimental-network-imports by rsalim0 · Pull Request #53998 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See also: #53822 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: James M Snell <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
TSC reached a consensus to remove this feature. So, there's no reason to land this PR anymore.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@RafaelGSS I disagree, I think it makes sense to land this to fix the behavior on release lines (also TSC consensus is not exactly relevant, it's up to Node.js collaborators, not the TSC, unless collaborators can't find consensus) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I think in that case it should just be targeting release lines, instead of main? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Also, it seems the diff here isn't working, there are multiple relevant test failures, maybe there's some git error (OP mentioned a test case in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I tried checking out this branch and fixing the tests, unfortunately it's apparent that Thanks for sending this PR, and sorry it won't work out this time! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Import data: from data: should be allowed
There was an error while loading. Please reload this page.