GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: run license-builder by github-actions[bot] · Pull Request #54322 · nodejs/node

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
doc: run license-builder
eb52550
@github-actions github-actions Bot added the meta Issues and PRs related to the general management of the project. label Aug 12, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Aug 12, 2024
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c-ares/c-ares@595cf21

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
marco-ippolito
marco-ippolito approved these changes Aug 12, 2024
View reviewed changes
aymen94
aymen94 approved these changes Aug 12, 2024
View reviewed changes
richardlau
richardlau previously approved these changes Aug 12, 2024
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 12, 2024
@avivkeller avivkeller removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 12, 2024
@avivkeller

avivkeller commented Aug 12, 2024

Copy link
Copy Markdown
Member

Hey, just wanted to point out that the license builder script accounted for the header, so if this lands, the license wouldn't match that of c-ares.

The script should be updated instead of landing this IMO.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 12, 2024
@avivkeller

avivkeller commented Aug 12, 2024

Copy link
Copy Markdown
Member

I suggest not landing this, and instead landing #54335
richardlau and lpinca reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 12, 2024
@richardlau
richardlau dismissed their stale review August 12, 2024 15:12

Would prefer to land #54335

@targos targos closed this Aug 13, 2024
@targos
targos deleted the actions/license-builder branch August 13, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes
@richardlau richardlau richardlau left review comments
+2 more reviewers
@targos targos targos approved these changes
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @avivkeller @targos @richardlau @aymen94 @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.