GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tls: wrap ssl errors in ECONNRESET by Uzlopak · Pull Request #54492 · nodejs/node

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

For discussion.

I think we should not break userland, by passing the OpenSSL Errors directly to userland. IMHO they need to be wrapped accordingly.

This PR is not passing all tests and is for demonstration purposes.

Especially notifying:
@mcollina
@RafaelGSS
@nodejs/undici

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@Uzlopak
tls: wrap ssl errors in ECONNRESET
be1f3f9
@Uzlopak Uzlopak mentioned this pull request Aug 22, 2024
Nightly tests are failing nodejs/undici#3464
Closed
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Aug 22, 2024
@Uzlopak Uzlopak mentioned this pull request Aug 22, 2024
v22.7.0 proposal #54452
Merged
@codecov

codecov Bot commented Aug 22, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (7c76fa0) to head (be1f3f9).
⚠️ Report is 5467 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54492      +/-   ##
==========================================
+ Coverage   87.31%   87.33%   +0.01%     
==========================================
  Files         648      649       +1     
  Lines      182359   182530     +171     
  Branches    34979    35028      +49     
==========================================
+ Hits       159235   159411     +176     
+ Misses      16389    16381       -8     
- Partials     6735     6738       +3
Files with missing lines Coverage Δ
lib/_tls_wrap.js 93.37% <100.00%> (-0.02%) ⬇️
lib/internal/errors.js 94.44% <100.00%> (ø)

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@avivkeller avivkeller closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Uzlopak @nodejs-github-bot @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.