GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — buffer: correctly apply prototype to cloned `File` / `Blob` by avivkeller · Pull Request #55138 · nodejs/node

Conversation

@avivkeller

@avivkeller avivkeller commented Sep 26, 2024

Copy link
Copy Markdown
Member

Followup #47613
Reference #55067

The prototype of the transferred File / Blob should be equal to it's closest transferable superclass. This PR applies the same change as #55067 did to Streams to Files and Blobs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@avivkeller
buffer: correctly apply prototype to cloned File / Blob
f2dc258
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 26, 2024
@avivkeller avivkeller added buffer Issues and PRs related to the buffer subsystem. web-standards Issues and PRs related to web-platform APIs and standards compliance. labels Sep 26, 2024
H4ad
H4ad approved these changes Sep 26, 2024
View reviewed changes
@avivkeller avivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 26, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62796/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Sep 26, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (812806a) to head (f2dc258).
Report is 75 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55138      +/-   ##
==========================================
- Coverage   88.24%   88.23%   -0.01%     
==========================================
  Files         651      651              
  Lines      183905   183907       +2     
  Branches    35864    35866       +2     
==========================================
- Hits       162286   162279       -7     
- Misses      14905    14911       +6     
- Partials     6714     6717       +3
Files with missing lines Coverage Δ
lib/internal/blob.js 99.80% <100.00%> (+<0.01%) ⬆️
lib/internal/file.js 97.36% <100.00%> (+0.01%) ⬆️

... and 23 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Sep 27, 2024
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 27, 2024
jasnell
jasnell approved these changes Sep 28, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 28, 2024
@nodejs-github-bot
nodejs-github-bot merged commit f805d0b into nodejs:main Sep 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Landed in f805d0b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 4, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@H4ad H4ad H4ad approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. buffer Issues and PRs related to the buffer subsystem. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. web-standards Issues and PRs related to web-platform APIs and standards compliance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@avivkeller @nodejs-github-bot @jasnell @H4ad @aduh95 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.