GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "test_runner: ignore unmapped lines for coverage" by avivkeller · Pull Request #55339 · nodejs/node

Conversation

avivkeller commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Reverts #55228

This reverts a PR that was intended to fix #54753, however, the tests that it added where not accurate, and it actually does not pass the tests that it should pass.

Once this lands, I'll open a follow up with tests for this behavior so that this doesn't happen again.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 and bricss reacted with thumbs up emoji

All reactions

👍 2 reactions


          Revert "test_runner: ignore unmapped lines for coverage"

3b7f3d6

This reverts commit 3a42085.

nodejs-github-bot commented Oct 9, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/test_runner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner Issues and PRs related to the test runner subsystem. labels

Oct 9, 2024

avivkeller mentioned this pull request

Oct 9, 2024

test_runner: fix coverage report when --enable-source-maps is provided #55228

Merged

avivkeller added test

Issues and PRs related to Node.js core tests and test infrastructure.

revert

PRs that revert previously landed PRs.

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels

Oct 9, 2024

cjihrig commented Oct 9, 2024

Copy link

Copy Markdown

Contributor

Please drop the second commit. Just the revert.

avivkeller reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 commented Oct 9, 2024

Copy link

Copy Markdown

Contributor

#55228 (comment) any consideration on this comment?

Also, would you point which tests are failing, @redyetidev ? (if this info is public)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller removed the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label

Oct 9, 2024

cjihrig approved these changes

Oct 9, 2024

View reviewed changes

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 9, 2024

avivkeller added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 9, 2024

avivkeller commented Oct 9, 2024

Copy link

Copy Markdown

Member Author

Also, would you point which tests are failing, @redyetidev ? (if this info is public)

(From @cjihrig)

If source maps are enabled, coverage should be based on the original source. If a function in the original source is uncovered, it should be reported as uncovered.

I'm assuming the function is not mapped because of some dead code elimination or similar optimization during transpilation. That doesn't change the fact that it exists in the original source and is never executed.

You can see this if you compare --enable-source-maps to running without the flag. While the output should be same, after your PR, there are pretty distinct differences.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller mentioned this pull request

Oct 9, 2024

--experimental-test-coverage falsely reports missing coverage where TS source is import type #54753

Closed

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 9, 2024

nodejs-github-bot commented Oct 9, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63016/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller mentioned this pull request

Oct 9, 2024

2024-10-16, Version 23.0.0 (Current) #55338

Merged

atlowChemi approved these changes

Oct 9, 2024

View reviewed changes

avivkeller added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label

Oct 9, 2024

avivkeller commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Fast tracking for the upcoming proposal(s).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Oct 9, 2024

Copy link

Copy Markdown

Contributor

Fast-track has been requested by @redyetidev. Please 👍 to approve.

aduh95 and richardlau reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (7178588) to head (3b7f3d6).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55339      +/-   ##
==========================================
+ Coverage   88.38%   88.41%   +0.02%     
==========================================
  Files         652      652              
  Lines      186740   186714      -26     
  Branches    36036    36031       -5     
==========================================
+ Hits       165058   165078      +20     
+ Misses      14934    14896      -38     
+ Partials     6748     6740       -8

Files with missing lines	Coverage Δ
lib/internal/test_runner/coverage.js	`64.54% <100.00%> (+0.82%)`	⬆️

... and 34 files with indirect coverage changes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller mentioned this pull request

Oct 9, 2024

V22.10.0 proposal #55343

Merged

aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels

Oct 10, 2024

nodejs-github-bot commented Oct 10, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63027/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller commented Oct 10, 2024

Copy link

Copy Markdown

Member Author

@RafaelGSS said that he'll do a final sync with main later today. It's imperative that this fix lands before that sync. If not, --enable-source-maps with coverage reporting will be broken.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig commented Oct 10, 2024

Copy link

Copy Markdown

Contributor

We need a green CI first.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 10, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63030/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS commented Oct 10, 2024

Copy link

Copy Markdown

Member

@RafaelGSS said that he'll do a final sync with main later today. It's imperative that this fix lands before that sync. If not, --enable-source-maps with coverage reporting will be broken.

I can drop the original commit if this doesn't land. No need to rush if CI isn't green

avivkeller reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller commented Oct 10, 2024

Copy link

Copy Markdown

Member Author

If this isn't green by the time you do your final sync, that's probably the best idea. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 11, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63048/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 11, 2024

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Oct 11, 2024

nodejs-github-bot commented Oct 11, 2024

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/55339
✔  Done loading data for nodejs/node/pull/55339
----------------------------------- PR info ------------------------------------
Title      Revert "test_runner: ignore unmapped lines for coverage" (#55339)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:revert-55228-issue-55106 -> nodejs:main
Labels     test, fast-track, author ready, needs-ci, revert, dont-land-on-v18.x, test_runner, dont-land-on-v20.x, dont-land-on-v22.x
Commits    1
 - Revert "test_runner: ignore unmapped lines for coverage"
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55339
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55339
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 09 Oct 2024 17:59:26 GMT
   ✔  Approvals: 2
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/55339#pullrequestreview-2357863538
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55339#pullrequestreview-2358022594
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 6 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-11T08:57:38Z: https://ci.nodejs.org/job/node-test-pull-request/63048/
- Querying data for job/node-test-pull-request/63048/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/11291355072

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Oct 11, 2024

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 11, 2024

nodejs-github-bot merged commit ccd4faf into nodejs:main

Oct 11, 2024

nodejs-github-bot commented Oct 11, 2024

Copy link

Copy Markdown

Collaborator

Landed in ccd4faf

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ThePlenkov mentioned this pull request

Dec 8, 2025

test_runner: Add option to exclude empty lines from coverage report #60996

Open

Reviewers

cjihrig

cjihrig approved these changes

atlowChemi

atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

dont-land-on-v22.x

PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

needs-ci

PRs that need a full CI run.

revert

PRs that revert previously landed PRs.

test_runner

Issues and PRs related to the test runner subsystem.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--experimental-test-coverage falsely reports missing coverage where TS source is import type

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

avivkeller commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 9, 2024

Uh oh!

cjihrig commented Oct 9, 2024

Uh oh!

geeksilva97 commented Oct 9, 2024

Uh oh!

avivkeller commented Oct 9, 2024

Uh oh!

nodejs-github-bot commented Oct 9, 2024

Uh oh!

avivkeller commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 9, 2024

Uh oh!

codecov Bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Oct 10, 2024

Uh oh!

avivkeller commented Oct 10, 2024

Uh oh!

cjihrig commented Oct 10, 2024

Uh oh!

nodejs-github-bot commented Oct 10, 2024

Uh oh!

RafaelGSS commented Oct 10, 2024

Uh oh!

avivkeller commented Oct 10, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

nodejs-github-bot commented Oct 11, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

avivkeller commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

avivkeller commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.