GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — - by alexsch01 · Pull Request #55729 · nodejs/node

Conversation

@alexsch01

@alexsch01 alexsch01 commented Nov 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Fixes https://github.com/nodejs/node/pull/54677 should be backported to NodeJS 20 Branch #55726

This reverts commit a833c9e.

PR-URL: #54677
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Michaël Zasso [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@avivkeller @alexsch01
Revert "console: colorize console error and warn"
3b9a6cd 
This reverts commit a833c9e.

PR-URL: #54677
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x labels Nov 5, 2024
@alexsch01 alexsch01 changed the title Revert "console: colorize console error and warn" [v20.x] Revert "console: colorize console error and warn" Nov 5, 2024
@avivkeller

avivkeller commented Nov 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please change the base branch to v20.x-staging.

Again, I don't think this even needs a backport PR, as the commit lands cleanly, and can be included in the next release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexsch01
alexsch01 deleted the branch nodejs:v20.x November 5, 2024 17:12
@alexsch01 alexsch01 closed this Nov 5, 2024
@alexsch01
alexsch01 deleted the v20.x branch November 5, 2024 17:12
@alexsch01

alexsch01 commented Nov 5, 2024

Copy link
Copy Markdown
Contributor Author

@redyetidev does renaming my branch and doing another PR work?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller

avivkeller commented Nov 5, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

IMHO I would hold off on the backport PR, and see if it is even needed. I'd wait until v20.X is prepared, and then see if it's even needed
alexsch01 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexsch01 alexsch01 changed the title [v20.x] Revert "console: colorize console error and warn" - Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@alexsch01 @avivkeller @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.