GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix history info for URLSearchParams by skyclouds2001 · Pull Request #55840 · nodejs/node

Conversation

@skyclouds2001

@skyclouds2001 skyclouds2001 commented Nov 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs: #17365
Refs: #9484
Refs: #7448
Refs: #10801
Refs: mdn/browser-compat-data#24998

Add version table for:

  • new URLSearchParams(string)
    • added in v7.5.0, taken from bcd
    • backlogged to v6.13.0, see Backport WHATWG URL to 6.x #17365
  • URLSearchParams.prototype.{entries,forEach,keys,values}
    • added in v7.3.0, see url: Improve WHATWG URLSearchParams spec compliance #9484
    • backlogged to v6.13.0, see Backport WHATWG URL to 6.x #17365
  • other methods & properties
    • mostly added (if doesn't have version table previously) in v7.0.0, see url: adding WHATWG URL support #7448, and then backlogged to v6.13.0

Test screenshots taken from mdn/browser-compat-data#24998:

image

image

image

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. url Issues and PRs related to the legacy built-in url module. labels Nov 13, 2024
This was referenced Nov 13, 2024
Missing version info about some members of URL class & URLSearchParams class #55806
Closed
doc: missing data for URLSearchParams(urlSearchParams) constructor #55841
Closed
@skyclouds2001
skyclouds2001 marked this pull request as ready for review November 13, 2024 19:14
lpinca
lpinca reviewed Nov 13, 2024
View reviewed changes
Comment thread doc/api/url.md Outdated
@@ -771,10 +771,22 @@ console.log(myURL.href);

#### `new URLSearchParams()`

<!-- YAML
added:
- v7.0.0

@lpinca lpinca Nov 13, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class was added in v7.5.0 and the constructor in v7.0.0 🤔 ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skyclouds2001 skyclouds2001 Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! my mistake

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aduh95 aduh95 Nov 13, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those additions are adding much, it's already implied that if there are no history data, it inherits from the class, having redundant info only increases the risk to let a mistake pass through

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aduh95 aduh95 Nov 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so the nuance is that require('url').URLSearchParams only existed after 7.5.0 (021338d), but the actual class was added along the rest of the URL API (a8ece14) and was accessible via new URL().searchParams. I wonder if any of our user would be sensible to the nuance – hopefully there are no v7.x users left so it doesn't matter anyway.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skyclouds2001 skyclouds2001 Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that this history info may be useless for users (it's quite impossible to see v7.x users left)

But it is required in some cases, like browser-compat-data. And it is normal way to add history info for every single feature (especially for new features, like web crypto, web stream, worker threads). Also, parent feature and children feature are not always have the same history info, like in this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skyclouds2001
skyclouds2001 force-pushed the history-URLSearchParams branch from ac38343 to 273830f Compare November 14, 2024 03:28
@aduh95

aduh95 commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

The commit message does not match the changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skyclouds2001
doc: fix history info for URLSearchParams
771859f
@skyclouds2001
skyclouds2001 force-pushed the history-URLSearchParams branch from 273830f to 771859f Compare November 14, 2024 19:20
@skyclouds2001

skyclouds2001 commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

The commit message does not match the changes

Fixed!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@avivkeller avivkeller closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments
@aduh95 aduh95 aduh95 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@skyclouds2001 @aduh95 @lpinca @nodejs-github-bot @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.