GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: added restart log in test-runner/runner.js by sivakumar-77 · Pull Request #57375 · nodejs/node

Conversation

@sivakumar-77

@sivakumar-77 sivakumar-77 commented Mar 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #57206

Added restart log in test-runner/runner.js to log with timestamp and test-file
whenever the test file is restart testing in --watch mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sivakumar-77
lib: restart log in runner.js
6c4d2d5 
Fixes nodejs#57206

Added restart log in test-runner/runner.js to log with timestamp and test-file, whenever the test file is restart testing in `--watch` mode.
@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Mar 8, 2025
@sivakumar-77 sivakumar-77 changed the title add: restart log in test-runner/runner.js lib: added restart log in test-runner/runner.js Mar 8, 2025
@pmarchini

pmarchini commented Mar 8, 2025

Copy link
Copy Markdown
Member

Hey @sivakumar-77, thanks for opening this PR! 🚀

I think we should avoid adding process.stdout.write directly inside the runner restart logic.

I would suggest adding a new event, like the existing one, test:watch:drained, to allow users to customise the behaviour while avoiding unwanted output in existing custom reporters.
I would then suggest handling the new event in the internal reporters (spec, tap, etc.).

Could you also please add tests to cover this feature?
atlowChemi, sivakumar-77, and MoLow reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pmarchini pmarchini changed the title lib: added restart log in test-runner/runner.js test_runner: added restart log in test-runner/runner.js Mar 8, 2025
@sivakumar-77

sivakumar-77 commented Mar 9, 2025

Copy link
Copy Markdown
Author

Hey @pmarchini thanks for the feedback! 🙌

That makes sense—I’ll update the PR to introduce a new event instead of directly modifying the runner restart logic. I’ll also update the internal reporters to handle it appropriately.

I'll add tests to cover this feature as well. Thanks
pmarchini reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JacopoPatroclo JacopoPatroclo mentioned this pull request Apr 16, 2025
test_runner: emit test:watch:restarted event on watched file changes #57903
Merged
@JacopoPatroclo

JacopoPatroclo commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

@pmarchini I've taken over this piece of work here #57903
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pmarchini

pmarchini commented Apr 17, 2025

Copy link
Copy Markdown
Member

Hey @sivakumar-77, as this PR seems stale, shall we close it, or are you still working on it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sivakumar-77 sivakumar-77 closed this Apr 17, 2025
@OkunadeNaheem OkunadeNaheem mentioned this pull request Jul 13, 2025
test-runner: write out timestamp as first line in watch mode #57206
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-runner: write out timestamp as first line in watch mode

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sivakumar-77 @nodejs-github-bot @pmarchini @JacopoPatroclo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.