GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: remove `recursive` option from rmdir by LiviaMedeiros · Pull Request #57784 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Apr 7, 2025

Copy link
Copy Markdown
Member

This moves DEP0147: fs.rmdir(path, { recursive: true }) to EOL.

The recursive option was runtime deprecated since v16.0.0 in favor of rm() function. Maybe it is time to remove it.

cc @nodejs/fs because fs Issues and PRs related to file-system APIs and the fs module.
cc @nodejs/tsc because semver-major PRs that contain breaking changes and should be released in the next major version.
cc @addaleax because of concerns in the runtime deprecation PR #37302 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and ExE-Boss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@LiviaMedeiros
fs: remove recursive option from rmdir
f93c03a
@LiviaMedeiros LiviaMedeiros added fs Issues and PRs related to file-system APIs and the fs module. semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Apr 7, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 7, 2025
@LiviaMedeiros LiviaMedeiros added the needs-citgm PRs that need a CITGM CI run. label Apr 7, 2025
@LiviaMedeiros
squash: fill PR number
4a7d563
mcollina
mcollina approved these changes Apr 7, 2025
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codecov

codecov Bot commented Apr 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (33f6e1e) to head (f9034bc).
Report is 559 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #57784    +/-   ##
========================================
  Coverage   90.24%   90.25%            
========================================
  Files         630      630            
  Lines      185245   185136   -109     
  Branches    36299    36286    -13     
========================================
- Hits       167173   167090    -83     
+ Misses      11018    10988    -30     
- Partials     7054     7058     +4
Files with missing lines Coverage Δ
lib/fs.js 98.25% <100.00%> (-0.02%) ⬇️
lib/internal/fs/promises.js 98.22% <ø> (-0.02%) ⬇️
lib/internal/fs/utils.js 99.68% <100.00%> (-0.01%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bjohansebas
bjohansebas approved these changes Apr 7, 2025
View reviewed changes
MoLow
MoLow approved these changes Apr 7, 2025
View reviewed changes
@LiviaMedeiros
squash: update deprecation description
f9034bc
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025 •
edited by LiviaMedeiros
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66110/

CITGM:

  • main https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3576/
  • PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3577/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jazelly
jazelly approved these changes Apr 7, 2025
View reviewed changes
RaisinTen
RaisinTen approved these changes Apr 8, 2025
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66172/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Apr 9, 2025
View reviewed changes
@mcollina

mcollina commented Apr 10, 2025

Copy link
Copy Markdown
Member

There seem to be a lot of CITGM failures compared to main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros LiviaMedeiros mentioned this pull request Jun 9, 2025
fs: move rmdir recursive option to end-of-life #58616
Merged
@LiviaMedeiros

LiviaMedeiros commented Jun 14, 2025

Copy link
Copy Markdown
Member Author

Closed in favour of #58616
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros LiviaMedeiros closed this Jun 14, 2025
@jasnell

jasnell commented Jun 14, 2025

Copy link
Copy Markdown
Member

oh! I had completely missed this @LiviaMedeiros ! Sorry about that :-*(
LiviaMedeiros reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros

LiviaMedeiros commented Jun 14, 2025

Copy link
Copy Markdown
Member Author

No worries; as long as the change lands, am happy with it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@jazelly jazelly jazelly approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

deprecations Issues and PRs related to deprecations. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@LiviaMedeiros @nodejs-github-bot @mcollina @jasnell @lpinca @MoLow @jazelly @RaisinTen @bjohansebas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.