GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — stream: readable read one buffer at a time by ronag · Pull Request #60441 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
I think some docs changes are needed
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Marked as semver-major. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I'm -1 on this unless there is a strong reason for it. Historically, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
The performance overhead is huge. As it stand we should at least add a note to avoid this api for anything performance sensitive.
Good point. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
What doc changes are you roughly asking for? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
a380c35 to
0798db8
Compare
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - stream: readable read one buffer at a time ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/20654449594 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/60441 ✔ Done loading data for nodejs/node/pull/60441 ----------------------------------- PR info ------------------------------------ Title stream: readable read one buffer at a time (#60441) Author Robert Nagy <[email protected]> (@ronag) Branch ronag:read-no-copy -> nodejs:main Labels stream, semver-major, author ready, needs-ci, needs-citgm Commits 1 - stream: readable read one buffer at a time Committers 1 - Robert Nagy <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60441 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 27 Oct 2025 18:44:50 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60441#pullrequestreview-3631894479 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60441#pullrequestreview-3632251382 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/60441#pullrequestreview-3635847744 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-05T21:27:50Z: https://ci.nodejs.org/job/node-test-pull-request/70687/ ℹ Last CITGM CI on 2026-01-05T09:54:54Z: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3663/ - Querying data for job/node-test-pull-request/70687/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187285768 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@nodejs/tsc can I get another approval? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in fadb214 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.