GeezerVison

Copy link

Copy Markdown

Member

codebytere marked this pull request as ready for review January 21, 2026 10:38

codebytere force-pushed the bssl-test-tweaks branch from f659ab0 to e21d796 Compare January 21, 2026 11:01

@@            Coverage Diff             @@
##             main   #61459      +/-   ##
==========================================
- Coverage   89.67%   89.65%   -0.02%     
==========================================
  Files         676      676              
  Lines      206469   206469              
  Branches    39537    39542       +5     
==========================================
- Hits       185157   185117      -40     
- Misses      13448    13491      +43     
+ Partials     7864     7861       -3     

codebytere force-pushed the bssl-test-tweaks branch from e21d796 to efdaebc Compare January 21, 2026 12:07

addaleax reviewed Jan 21, 2026

View reviewed changes

panva reviewed Jan 27, 2026

View reviewed changes

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: nodejs#61459 (comment)

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

codebytere requested review from addaleax and panva February 25, 2026 15:17

aduh95 reviewed Mar 13, 2026

View reviewed changes

codebytere force-pushed the bssl-test-tweaks branch 3 times, most recently from b7d8764 to b8ec581 Compare March 13, 2026 11:33

codebytere requested a review from aduh95 March 13, 2026 11:34

codebytere force-pushed the bssl-test-tweaks branch from b8ec581 to d27e019 Compare March 13, 2026 11:34

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

This hides a discrepancy between OpenSSL and BoringSSL, as
the latter returns lowercase hex values.

Refs: #61459 (comment)
PR-URL: #61752
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>