GeezerVison

Review requested:

• @nodejs/build
• @nodejs/tsc

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

Thanks @Renegade334 — applied both. Used your wording verbatim for the icu4c note, since you're right that make dist is an active build step rather than a matter of layout, and saying only that a clone isn't the way to do it is clearer than describing what to do with one. Also updated the archive name in the Windows section to -sources.tgz to match.

Pushed fixes for both failing lint jobs.

lint-js-and-md was flagging the note itself:

BUILDING.md
1010:2-1010:11 warning Use "<nothing>" instead of "Note that" prohibited-strings remark-lint

@Renegade334 — that's on your suggested wording rather than anything you could have known about; prohibited-strings bans "Note that" repo-wide. I've kept your phrasing and just dropped the opening:

(Simply cloning the icu4c repository will not work here; the source directory
must have been unpacked from the compiled -sources archive.)

lint-commit-message was failing on not ok 6 signed-off-by. That was true of the original commit on this PR as well, so it had been failing since the branch was opened — both commits now carry a Signed-off-by trailer.

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✘  Requested Changes: 1
   ✘  - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/62011#pullrequestreview-5043250790

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

- Loading data for nodejs/node/pull/62011
✔  Done loading data for nodejs/node/pull/62011
----------------------------------- PR info ------------------------------------
Title      doc: clarify ICU source layout for --with-icu-source (#62011)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     skdas20:docs/clarify-icu-source-layout-60947 -> nodejs:main
Labels     doc, build, commit-queue, commit-queue-squash, stale
Commits    2
 - doc: clarify ICU source layout for configure
 - doc: apply review feedback on ICU source archive wording
Committers 1
 - Sumit Kumar Das <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/62011
Reviewed-By: René <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62011
Reviewed-By: René <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 26 Feb 2026 18:36:34 GMT
   ✘  Requested Changes: 1
   ✘  - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/62011#pullrequestreview-5043250790
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/62011#pullrequestreview-5042759412
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

Thanks @sxa — applied the download page change, in both places (the Windows section had the old link too).

On the other suggestion, I can't take it as-is: prohibited-strings bans "Note that" repo-wide, and that's what lint-js-and-md was failing on before:

BUILDING.md
1010:2-1010:11 warning Use "<nothing>" instead of "Note that" prohibited-strings remark-lint

The current text keeps @Renegade334's wording with just the opening dropped:

(Simply cloning the icu4c repository will not work here; the source directory
must have been unpacked from the compiled -sources archive.)

Happy to reword further if that reads awkwardly to you — I just can't restore the "Note that" without the lint failing again.

@sxa I've applied the download-page change in both places. Could you take another look when you have a moment? The other suggestion conflicts with the repo-wide prohibited-strings lint, as explained above.

Thanks @sxa and @Renegade334 for the approvals! The last commit-queue run (Aug 27) failed only on the since-resolved change request. Could a collaborator add request-ci and commit-queue when convenient? Happy to squash or rebase first if you'd prefer.