GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — lib: fix modulo sign in webidl convertToInt by deepview-autofix · Pull Request #62940 · nodejs/node Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #62940 +/- ## ========================================== - Coverage 89.66% 89.63% -0.03% ========================================== Files 706 706 Lines 219370 219424 +54 Branches 42065 42074 +9 ========================================== - Hits 196694 196681 -13 - Misses 14586 14633 +47 - Partials 8090 8110 +20
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Calculation at 64 bits is still off, will redo |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
598cfec to
0c87f49
Compare
There was an error while loading. Please reload this page.
|
I rewrote the whole thing and added more tests |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
0c87f49 to
a5ec26f
Compare
Co-Authored-By: DeepView Autofix <[email protected]> Assisted-by: Claude <[email protected]> Signed-off-by: Nikita Skovoroda <[email protected]>
a5ec26f to
76ad558
Compare
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| // 9. Set x to IntegerPart(x). | ||
| x = integerPart(x); | ||
|
|
||
| // Following the exact algorithm looses precision on signed modulo in 64-bit |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| // Following the exact algorithm looses precision on signed modulo in 64-bit | |
| // Following the exact algorithm loses precision on signed modulo in 64-bit |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing in favor of #62979 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.