GeezerVison

A client request whose method defaults to no chunked encoding (GET,
HEAD, DELETE, OPTIONS, TRACE) skipped both Content-Length and
Transfer-Encoding even when a payload was written. The payload was
still sent, so the peer read those bytes as the start of the next
request, which allows request smuggling.

Frame such requests like any other: use Content-Length when the length
is known and a chunked Transfer-Encoding when it is not. Server
responses and requests with no payload keep the previous behaviour,
and CONNECT is left untouched because its payload is tunnelled data
that must not be re-framed.

Headers can be rendered before anything is written, for example when
the headers are passed as an array or an Expect header is set. Track
whether a payload write actually happened so that case is not mistaken
for a body of unknown length.

The two known_issues tests covering this now pass and move to
parallel. They also asserted a response body for HEAD, which cannot
have one, and compared buffers with strictEqual, so both are corrected
in the move.

Fixes: nodejs#27880
Refs: nodejs#34066
Refs: nodejs#60718
Signed-off-by: Avocado <[email protected]>

A client request that writes a payload is now framed with a chunked
Transfer-Encoding. When the body source is destroyed before EOF the
request ends without its terminating chunk, so the peer resets the
connection instead of seeing a clean close, and the echoed response
fails with ECONNRESET rather than ERR_STREAM_PREMATURE_CLOSE.

Signed-off-by: Avocado <[email protected]>

A client request that carries a payload is framed with Content-Length or
a chunked Transfer-Encoding, which is decided from the payload flag set
when a write reaches the message. The fast path for a known-length end()
renders the headers itself without going through that write, so the flag
was still unset and such requests were framed as if they had no payload.

Set the flag there as well, so a request whose whole payload is passed to
end() is framed like any other.

The pipeline test aborts a request body once the echoed response has been
received. Chunked writes are now coalesced, so the response arrives as a
single data event and counting events never reaches the abort. Count the
received bytes instead, the way the neighbouring case already does.

Signed-off-by: Avocado <[email protected]>