GeezerVison is showing github.com — deps: update inspector_protocol to c0045057ce801744c5e88596a2f1bab1802e by nodejs-github-bot · Pull Request #66653 · nodejs/node
Conversation
This is an automated update of inspector_protocol to c0045057ce801744c5e88596a2f1bab1802e.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
../../src/inspector_agent.cc:446:8: error: 'void node::inspector::{anonymous}::ChannelImpl::FallThrough(int, crdtp::span<unsigned char>, crdtp::span<unsigned char>)' marked 'override', but does not override
446 | void FallThrough(int call_id,
| ^~~~~~~~~~~
../../src/inspector_agent.cc: In member function 'void node::inspector::{anonymous}::ChannelImpl::dispatchProtocolMessage(const v8_inspector::StringView&)':
../../src/inspector_agent.cc:338:59: error: no matching function for call to 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>)'
338 | Dispatchable dispatchable(crdtp::SpanFrom(cbor_buffer));
| ^
../../src/inspector_agent.cc:338:59: note: there are 3 candidates
In file included from gen/src/node/inspector/protocol/Forward.h:15,
from gen/src/node/inspector/protocol/Protocol.h:18,
from gen/src/node/inspector/protocol/DOMStorage.h:10,
from ../../src/inspector/dom_storage_agent.h:7,
from ../../src/inspector_agent.cc:7:
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate 1: 'crdtp::Dispatchable::Dispatchable(crdtp::span<unsigned char>, std::string_view, crdtp::FallthroughCallback)'
124 | Dispatchable(span<uint8_t> serialized,
| ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:124:3: note: candidate expects 3 arguments, 1 provided
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 2: 'crdtp::Dispatchable::Dispatchable(const crdtp::Dispatchable&)'
110 | class CRDTP_EXPORT Dispatchable {
| ^~~~~~~~~~~~
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'const crdtp::Dispatchable&'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: candidate 3: 'crdtp::Dispatchable::Dispatchable(crdtp::Dispatchable&&)'
../../deps/inspector_protocol/crdtp/dispatch.h:110:20: note: no known conversion for argument 1 from 'crdtp::span<unsigned char>' {aka 'std::span<const unsigned char>'} to 'crdtp::Dispatchable&&'
../../src/inspector_agent.cc:345:21: error: 'DispatchResult' is not a member of 'crdtp::UberDispatcher'
345 | UberDispatcher::DispatchResult result =
| ^~~~~~~~~~~~~~
../../src/inspector_agent.cc:347:10: error: 'result' was not declared in this scope; did you mean 'ada::result'?
347 | if (!result.MethodFound()) {
| ^~~~~~
| ada::result
In file included from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/url_pattern.h:15,
from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/parser-inl.h:8,
from /nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada.h:40,
from ../../src/node_url.h:7,
from ../../src/inspector_agent.cc:29:
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
44 | using result = tl::expected<result_type, ada::errors>;
| ^~~~~~
../../src/inspector_agent.cc:352:5: error: 'result' was not declared in this scope; did you mean 'ada::result'?
352 | result.Run();
| ^~~~~~
| ada::result
/nix/store/adrkcplbsaxnvj2w751xsvzhm4cfar8g-ada-4.0.0/include/ada/implementation.h:44:7: note: 'ada::result' declared here
44 | using result = tl::expected<result_type, ada::errors>;
| ^~~~~~
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Pushed a commit fixing the build failures.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
codecov
Bot
commented
Nov 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.72%. Comparing base (5f602d5) to head (339d2a9).
⚠️ Report is 37 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #66653 +/- ##
==========================================
+ Coverage 90.68% 90.72% +0.04%
==========================================
Files 797 798 +1
Lines 279574 280083 +509
Branches 53778 53890 +112
==========================================
+ Hits 253525 254115 +590
+ Misses 16344 16276 -68
+ Partials 9705 9692 -13
... and 75 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
cjihrig
cjihrig approved these changes
aduh95
Awaiting requested review from aduh95
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
commit-queue-rebase
PRs the Commit Queue should land as multiple self-contained commits.
dependencies
PRs that add, update, or configure Node.js dependencies.
inspector
Issues and PRs related to the V8 inspector protocol.
needs-ci
PRs that need a full CI run.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|