GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: do not include the vendored simdutf with `--shared-simdutf` by ziyao233 · Pull Request #67410 · nodejs/node

Conversation

@ziyao233

@ziyao233 ziyao233 commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Different versions of simdutf may provide different implementations for the same name, for example, the vendored version provides a symbol for simdutf::find(),

simdutf_warn_unused const char *find(const char *start, const char *end,
char character) noexcept;

while upstream simdutf 9.3.3 inlines it,

simdutf_warn_unused simdutf_really_inline simdutf_constexpr23 const char * find(const char *start, const char end, char character) noexcept {
/
An inline function */
...
}

However, the vendored simdutf's headers are currently unconditionally included for merve, regardless whether the shared simdutf is linked against or not, leading to missing symbols at linking time like

mold: error: undefined symbol: simdutf::find(char const*, char const*, char)

referenced by merve.cpp
obj/deps/merve/libmerve.a(obj/deps/merve/merve.merve.o):(lexer::CJSLexer::addReexport(std::__1::basic_string_view<char, std::__1::char_traits>, unsigned int))
referenced by merve.cpp
obj/deps/merve/libmerve.a(obj/deps/merve/merve.merve.o):(lexer::CJSLexer::addExport(std::__1::basic_string_view<char, std::__1::char_traits>, unsigned int))

Do not include the vendored simdutf when compiling merve if shared simdutf is used to ensure the headers match the linked library.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Nov 11, 2026
aduh95
aduh95 approved these changes Nov 12, 2026
View reviewed changes
@ziyao233 @aduh95
build: do not include vendored simdutf with --shared-simdutf
b99a89f
Do not include the vendored simdutf when compiling merve if shared
simdutf is used to ensure the headers match the linked library.

Signed-off-by: Yao Zi <[email protected]>
@aduh95
aduh95 force-pushed the build/merve-simdutf-include branch from dfa62df to b99a89f Compare November 12, 2026 09:30
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 12, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78995/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 changed the title deps: merve: Don't include the vendored simdutf with --shared-simdutf build: do not include the vendored simdutf with --shared-simdutf Nov 12, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78997/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ziyao233 @nodejs-github-bot @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.