GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib,test: update unhandled rejections link by cjihrig · Pull Request #41195 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Dec 16, 2021

Copy link
Copy Markdown
Contributor

The link in the warning printed on unhandled rejection is no longer valid. This commit updates the URL to the correct target.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig
lib,test: update unhandled rejections link
77c1c5d 
The link in the warning printed on unhandled rejection is
no longer valid. This commit updates the URL to the correct target.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Dec 16, 2021
DerekNonGeneric
DerekNonGeneric approved these changes Dec 16, 2021
View reviewed changes

@DerekNonGeneric DerekNonGeneric left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They actually both seem to be functional links pointing to the same place:

  • https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode
  • https://nodejs.org/api/cli.html#--unhandled-rejectionsmode

I think I prefer the one you are proposing tho (it looks a bit better/cleaner/easier to read).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig

cjihrig commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Hm, maybe this is a Chrome issue or something with my local machine. Both links work for me in Firefox. I'm going to close this - no need go changing things for no reason.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cjihrig @DerekNonGeneric @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.