GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix: Added transition between light & dark mode by benhalverson · Pull Request #1071 · nodejs/nodejs.dev

This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Conversation

@benhalverson

@benhalverson benhalverson commented Dec 3, 2020

Copy link
Copy Markdown
Member

Description

This PR fixes #1068 by adding a CSS transition between light mode and dark mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benhalverson added 30 commits March 30, 2020 01:09
@benhalverson
refactor(.gitignore): Added .env.production to .gitignore
c7626ec
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
778a0a5
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
a6ec024
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
5e4c6d5
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
a3e365c
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
4f13c67
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
d621934
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
243158f
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
5032628
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
41a1796
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
235e735
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
e0924dc
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
fc9447a
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
98c33ef
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
bea1ca7
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
7c9dcf0
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
0ac688d
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
d9c2325
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
903a7c3
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
b99ea8d
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
ca244ab
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
9edf0ba
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
718a9f4
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
41b3a9e
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
c57b32b
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
55e850b
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
ee89ddd
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev
e245ba5
@benhalverson
Merge branch 'master' of github.com:benhalverson/nodejs.dev
ac0628e
@benhalverson
Merge branch 'master' of github.com:nodejs/nodejs.dev into master
461ecbe
@benhalverson
fix(transition): Added light animation between light and dark mode
bcbe273
@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Dec 3, 2020
@github-actions github-actions Bot removed the create-preview Generate preview on staging.nodejs.dev label Dec 3, 2020
@github-actions

github-actions Bot commented Dec 3, 2020

Copy link
Copy Markdown

Please find a preview at: https://staging.nodejs.dev/1071/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benhalverson benhalverson mentioned this pull request Dec 3, 2020
Add dark mode nodejs/node#36313
Merged
2 of 4 tasks
@benhalverson
Merge branch 'master' into light-dark-transition
5794326
rodion-arr
rodion-arr approved these changes Dec 3, 2020
View reviewed changes

@rodion-arr rodion-arr left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
designMoreWeb
designMoreWeb approved these changes Dec 4, 2020
View reviewed changes

@designMoreWeb designMoreWeb left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benhalverson
Merge branch 'master' into light-dark-transition
c8c6fb9
@benhalverson
benhalverson merged commit be95adb into nodejs:master Dec 4, 2020
@marcustisater

marcustisater commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Nice!

@benhalverson btw how did you end up with 32 merge commits? 😂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@rodion-arr rodion-arr rodion-arr approved these changes
@designMoreWeb designMoreWeb designMoreWeb approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There is no transition for the dark/light mode toggler

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@benhalverson @marcustisater @rodion-arr @designMoreWeb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.