GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — feat(blog): add more codemod to migrations guides by AugustinMauroy · Pull Request #9086 · nodejs/nodejs.org Conversation
Member
DescriptionAs titled Related IssuesNo related issues Check List
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryLow Risk Overview The v22→v24 guide adds a one-shot Reviewed by Cursor Bugbot for commit 119e023. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #9086 +/- ## ========================================== + Coverage 75.07% 75.09% +0.02% ========================================== Files 102 102 Lines 9070 9118 +48 Branches 377 377 ========================================== + Hits 6809 6847 +38 - Misses 2257 2267 +10 Partials 4 4 ☔ View full report in Codecov by Harness. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the Node.js migration blog guides to better surface available codemods, including adding a new codemod entry to the v16→v18 guide and documenting how to run all v22→v24 codemods together.
Changes:
dns-lookup-options-coercion codemod section (with examples) to the v16→v18 migration guide.err-invalid-callback section heading from “Example” to “Examples”.Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/site/pages/en/blog/migrations/v22-to-v24.mdx | Adds guidance for running all codemods at once and clarifies list completeness via an AlertBox. |
| apps/site/pages/en/blog/migrations/v16-to-v18.mdx | Documents an additional codemod (dns-lookup-options-coercion) and aligns example heading wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
apps/site/pages/en/blog/migrations/v22-to-v24.mdx:72
If you want to run all of them at once, you can use the following command:
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
apps/site/pages/en/blog/migrations/v22-to-v24.mdx:75
npx codemod run @nodejs/v22-to-v24, but that preset/package does not appear to exist in the Codemod Registry (the registry URL for it returns 404). This would cause the command to fail for readers. Consider replacing it with a single shell command that chains the individual codemods listed below in this guide (or link to an actual preset if one exists).If you want to run all of them at once, you can use the following command:
```bash
npx codemod run @nodejs/v22-to-v24
</details>
Sorry, something went wrong.
There was an error while loading. Please reload this page.
📦 Build Size ComparisonSummary
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
the should be keep it's update blog post with new covered deprecation |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
These blog posts shouldn't change, they are point-in-time |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
ideally yes, but it's mean we post article only when we cover 100% of version deprecation which is take time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
In that case, a global "v22-to-v24" codemod should exist and be updated, not the blog. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
am i remembering correctly that we want to pivot all of these to something more durable than a blog post? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Should we close this PR or...? cc @AugustinMauroy |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
IMO no we should merge it to mention everything related to this migration |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
692dff70
Deployed
At least 1 approving review is required to merge this pull request.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.