GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — chore: feature-complete linting by avivkeller · Pull Request #9170 · nodejs/nodejs.org

Conversation

avivkeller commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

As titled. Completes the linter to conform to the spec.

See nodejs/node#62090 doc changes for how this changes node core's docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vercel Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
nodejs-org	Ready	Preview	Sep 23, 2026 3:03pm UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vercel Bot deployed to Preview

September 23, 2026 14:12

View deployment


          [WIP] feature-complete linting

34650bc

avivkeller force-pushed the lint branch from b2314be to 34650bc Compare

September 23, 2026 15:01

avivkeller marked this pull request as ready for review

September 23, 2026 15:02

avivkeller requested review from a team as code owners

September 23, 2026 15:02

Copilot AI lite review requested due to automatic review settings

September 23, 2026 15:02

avivkeller changed the title ~~[WIP] feature-complete linting~~ chore: feature-complete linting

Sep 23, 2026

Copilot started reviewing on behalf of avivkeller

September 23, 2026 15:02

View session

github-advanced-security Bot found potential problems

Sep 23, 2026

View reviewed changes

Comment thread

packages/remark-lint/src/rules/man-page-reference.mjs Dismissed

Uh oh!

There was an error while loading. Please reload this page.

vercel Bot deployed to Preview

September 23, 2026 15:03

View deployment

codecov Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 97.00708% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.22%. Comparing base (2c0cf20) to head (34650bc).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/remark-lint/src/utils/headings.mjs	85.06%	32 Missing and 1 partial ⚠️
packages/remark-lint/src/utils/signature.mjs	85.57%	14 Missing and 1 partial ⚠️
packages/remark-lint/src/utils/type-map.mjs	75.40%	15 Missing ⚠️
packages/remark-lint/src/rules/typed-list-item.mjs	91.30%	14 Missing ⚠️
packages/remark-lint/src/rules/link-targets.mjs	96.08%	9 Missing ⚠️
packages/remark-lint/src/context.mjs	98.39%	7 Missing ⚠️
packages/remark-lint/src/rule.mjs	91.66%	6 Missing ⚠️
...kages/remark-lint/src/rules/tag-comment-syntax.mjs	94.05%	6 Missing ⚠️
packages/remark-lint/src/utils/versions.mjs	95.57%	5 Missing ⚠️
...s/remark-lint/src/rules/no-redundant-stability.mjs	94.64%	3 Missing ⚠️
... and 12 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9170      +/-   ##
==========================================
+ Coverage   86.13%   90.22%   +4.08%     
==========================================
  Files          86      123      +37     
  Lines        6046     9531    +3485     
  Branches      357      845     +488     
==========================================
+ Hits         5208     8599    +3391     
- Misses        834      922      +88     
- Partials        4       10       +6

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Sep 23, 2026

Copy link

Copy Markdown

Contributor

📦 Build Size Comparison

Summary

Metric	Value
Old Total First Load JS	7.10 MB
New Total First Load JS	7.10 MB
Delta	-1.09 KB (-0.02%)

Changes

🔄 Modified Routes (4)

Route	Old First Load JS	New First Load JS	Delta
`/[locale]`	1.67 MB	1.67 MB	📉 -280.00 B (-0.02%)
`/[locale]/[...path]`	1.67 MB	1.67 MB	📉 -280.00 B (-0.02%)
`/[locale]/blog/[...path]`	1.67 MB	1.67 MB	📉 -280.00 B (-0.02%)
`/[locale]/download/archive/[version]`	1.67 MB	1.67 MB	📉 -280.00 B (-0.02%)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Copilot AI reviewed

Sep 23, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Eight moderate review findings remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Include path resolution context in the type map cache key · New

What changed in this PR

Rewrites @node-core/remark-lint to complete spec-compliant documentation linting with shared context, new rules, configurable presets, and expanded tests.

Changes:

Adds YAML, directive, heading, signature, type, stability, typed-list, link, and metadata rules.
Replaces legacy rules with base/API presets and shared option handling.
Expands rule coverage, fixtures, site configuration, and package metadata.

File	Description
`packages/remark-lint/src/utils/yaml.mjs`	YAML helpers
`packages/remark-lint/src/utils/versions.mjs`	Version validation
`packages/remark-lint/src/utils/types.mjs`	Type parsing and resolution
`packages/remark-lint/src/utils/typed-list.mjs`	Typed-list helpers
`packages/remark-lint/src/utils/type-map.mjs`	Type-map loading and caching
`packages/remark-lint/src/utils/signature.mjs`	Signature validation
`packages/remark-lint/src/utils/links.mjs`	File URL helpers
`packages/remark-lint/src/syntax.mjs`	Type annotation syntax
`packages/remark-lint/src/rules/yaml/validate-versions.mjs`	Legacy YAML version rule
`packages/remark-lint/src/rules/yaml/validate-changes.mjs`	Legacy YAML change rule
`packages/remark-lint/src/rules/yaml/ordered-yaml-keys.mjs`	Legacy YAML key ordering
`packages/remark-lint/src/rules/yaml/index.mjs`	Legacy YAML rule registry
`packages/remark-lint/src/rules/yaml-versions.mjs`	YAML version validation
`packages/remark-lint/src/rules/yaml-fields.mjs`	YAML field validation
`packages/remark-lint/src/rules/yaml-comment-syntax.mjs`	YAML comment syntax
`packages/remark-lint/src/rules/yaml-changes.mjs`	Change-record validation
`packages/remark-lint/src/rules/validate-links.mjs`	Link validation
`packages/remark-lint/src/rules/typed-list-prefix.mjs`	Typed-list prefixes
`packages/remark-lint/src/rules/typed-list-item.mjs`	Typed-list items
`packages/remark-lint/src/rules/typed-list-default.mjs`	Typed-list defaults
`packages/remark-lint/src/rules/type-annotation-syntax.mjs`	Type syntax validation
`packages/remark-lint/src/rules/type-annotation-style.mjs`	Type formatting
`packages/remark-lint/src/rules/type-annotation-resolution.mjs`	Type resolution
`packages/remark-lint/src/rules/tag-comment-syntax.mjs`	Tag comment validation
`packages/remark-lint/src/rules/stability-syntax.mjs`	Stability syntax
`packages/remark-lint/src/rules/signature-syntax.mjs`	Signature syntax
`packages/remark-lint/src/rules/signature-parameters.mjs`	Signature parameter validation
`packages/remark-lint/src/rules/required-metadata.mjs`	Metadata requirements
`packages/remark-lint/src/rules/required-directives.mjs`	Directive requirements
`packages/remark-lint/src/rules/prefer-reference-links.mjs`	Reference-link preference
`packages/remark-lint/src/rules/ordered-references.mjs`	Reference ordering
`packages/remark-lint/src/rules/ordered-definitions.mjs`	Definition ordering
`packages/remark-lint/src/rules/no-typed-list-in-prose.mjs`	Prose/list separation
`packages/remark-lint/src/rules/no-redundant-stability.mjs`	Stability redundancy
`packages/remark-lint/src/rules/no-frontmatter.mjs`	Frontmatter detection
`packages/remark-lint/src/rules/man-page-reference.mjs`	Man-page references
`packages/remark-lint/src/rules/invalid-type-reference.mjs`	Type reference validation
`packages/remark-lint/src/rules/invalid-deprecations.mjs`	Deprecation validation
`packages/remark-lint/src/rules/heading-multiple-forms.mjs`	Heading form validation
`packages/remark-lint/src/rules/heading-depth.mjs`	Heading depth validation
`packages/remark-lint/src/rules/heading-classification.mjs`	Heading classification
`packages/remark-lint/src/rules/hashed-self-reference.mjs`	Self-reference validation
`packages/remark-lint/src/rules/fenced-code-meta.mjs`	Code metadata validation
`packages/remark-lint/src/rules/entry-order.mjs`	Entry ordering
`packages/remark-lint/src/rules/duplicate-stability-nodes.mjs`	Stability-node duplication
`packages/remark-lint/src/rules/document-description.mjs`	Document descriptions
`packages/remark-lint/src/rules/directive-value.mjs`	Directive values
`packages/remark-lint/src/rules/directive-syntax.mjs`	Directive syntax
`packages/remark-lint/src/rules/directive-placement.mjs`	Directive placement
`packages/remark-lint/src/rules/deprecations.mjs`	Deprecation validation
`packages/remark-lint/src/rules/__tests__/yaml/validate-versions.test.mjs`	Legacy YAML version tests
`packages/remark-lint/src/rules/__tests__/yaml/validate-changes.test.mjs`	Legacy YAML change tests
`packages/remark-lint/src/rules/__tests__/yaml/ordered-yaml-keys.test.mjs`	Legacy YAML key tests
`packages/remark-lint/src/rules/__tests__/yaml-versions.test.mjs`	YAML version tests
`packages/remark-lint/src/rules/__tests__/yaml-fields.test.mjs`	YAML field tests
`packages/remark-lint/src/rules/__tests__/yaml-comment-syntax.test.mjs`	YAML syntax tests
`packages/remark-lint/src/rules/__tests__/yaml-changes.test.mjs`	Change-record tests
`packages/remark-lint/src/rules/__tests__/validate-links.test.mjs`	Link validation tests
`packages/remark-lint/src/rules/__tests__/utils.mjs`	Rule test utilities
`packages/remark-lint/src/rules/__tests__/typed-list-prefix.test.mjs`	Prefix tests
`packages/remark-lint/src/rules/__tests__/typed-list-item.test.mjs`	Typed-list item tests
`packages/remark-lint/src/rules/__tests__/typed-list-default.test.mjs`	Default tests
`packages/remark-lint/src/rules/__tests__/type-annotation-syntax.test.mjs`	Type syntax tests
`packages/remark-lint/src/rules/__tests__/type-annotation-style.test.mjs`	Type style tests
`packages/remark-lint/src/rules/__tests__/type-annotation-resolution.test.mjs`	Type resolution tests
`packages/remark-lint/src/rules/__tests__/tag-comment-syntax.test.mjs`	Tag comment tests
`packages/remark-lint/src/rules/__tests__/stability-syntax.test.mjs`	Stability tests
`packages/remark-lint/src/rules/__tests__/signature-syntax.test.mjs`	Signature syntax tests
`packages/remark-lint/src/rules/__tests__/signature-parameters.test.mjs`	Signature parameter tests
`packages/remark-lint/src/rules/__tests__/required-metadata.test.mjs`	Metadata tests
`packages/remark-lint/src/rules/__tests__/required-directives.test.mjs`	Directive requirement tests
`packages/remark-lint/src/rules/__tests__/prefer-reference-links.test.mjs`	Link preference tests
`packages/remark-lint/src/rules/__tests__/ordered-references.test.mjs`	Reference ordering tests
`packages/remark-lint/src/rules/__tests__/ordered-definitions.test.mjs`	Definition ordering tests
`packages/remark-lint/src/rules/__tests__/no-typed-list-in-prose.test.mjs`	Prose/list tests
`packages/remark-lint/src/rules/__tests__/no-redundant-stability.test.mjs`	Stability redundancy tests
`packages/remark-lint/src/rules/__tests__/no-frontmatter.test.mjs`	Frontmatter tests
`packages/remark-lint/src/rules/__tests__/man-page-reference.test.mjs`	Man-page tests
`packages/remark-lint/src/rules/__tests__/link-targets.test.mjs`	Link-target tests
`packages/remark-lint/src/rules/__tests__/invalid-type-reference.test.mjs`	Type reference tests
`packages/remark-lint/src/rules/__tests__/invalid-deprecations.test.mjs`	Deprecation tests
`packages/remark-lint/src/rules/__tests__/heading-multiple-forms.test.mjs`	Heading form tests
`packages/remark-lint/src/rules/__tests__/heading-depth.test.mjs`	Heading depth tests
`packages/remark-lint/src/rules/__tests__/heading-classification.test.mjs`	Heading classification tests
`packages/remark-lint/src/rules/__tests__/hashed-self-references.test.mjs`	Self-reference tests
`packages/remark-lint/src/rules/__tests__/fixtures/type-map.json`	Type-map fixture
`packages/remark-lint/src/rules/__tests__/fixtures/links/public/static/logo.svg`	Link fixture
`packages/remark-lint/src/rules/__tests__/fixtures/links/pages/en/about/previous-releases.mdx`	Link fixture
`packages/remark-lint/src/rules/__tests__/fixtures/links/doc/api/stream.md`	Link fixture
`packages/remark-lint/src/rules/__tests__/fixtures/links/doc/api/other.md`	Link fixture
`packages/remark-lint/src/rules/__tests__/fenced-code-meta.test.mjs`	Code metadata tests
`packages/remark-lint/src/rules/__tests__/entry-order.test.mjs`	Entry ordering tests
`packages/remark-lint/src/rules/__tests__/duplicate-stability-nodes.test.mjs`	Stability-node tests
`packages/remark-lint/src/rules/__tests__/document-description.test.mjs`	Description tests
`packages/remark-lint/src/rules/__tests__/directive-value.test.mjs`	Directive value tests
`packages/remark-lint/src/rules/__tests__/directive-syntax.test.mjs`	Directive syntax tests
`packages/remark-lint/src/rules/__tests__/directive-placement.test.mjs`	Directive placement tests
`packages/remark-lint/src/rules/__tests__/deprecations.test.mjs`	Deprecation tests
`packages/remark-lint/src/rule.mjs`	Rule definition framework
`packages/remark-lint/src/presets/base.mjs`	Base preset
`packages/remark-lint/src/presets/api.mjs`	API preset
`packages/remark-lint/src/preset.mjs`	Preset configuration
`packages/remark-lint/src/index.mjs`	Base preset export
`packages/remark-lint/src/api.mjs`	API preset export
`packages/remark-lint/src/__tests__/utils.mjs`	Shared test utilities
`packages/remark-lint/src/__tests__/preset.test.mjs`	Preset tests
`packages/remark-lint/src/__tests__/context.test.mjs`	Context tests
`packages/remark-lint/package.json`	Package metadata and dependencies
`apps/site/.remarkrc.json`	Site lint configuration
`.changeset/remark-lint-rewrite.md`	Major release changeset

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/remark-lint/src/utils/type-map.mjs

Comment on lines +23 to +29

		const key = String(source);

		if (!cache.has(key)) {
		cache.set(
		key,
		load(source, cwd).catch(error => {
		cache.delete(key);

avivkeller mentioned this pull request

Sep 24, 2026

Implement a Remark Linter to validate Semantic Version strings in metadata nodejs/doc-kit#1109

Closed

This branch was successfully deployed

1 active deployment

Preview — 34650bc7 Deployed Sep 23, 2026 by vercel[bot]

View deployment

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

+1 more reviewer

github-advanced-security[bot]

github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

avivkeller commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Sep 23, 2026

📦 Build Size Comparison

Summary

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

avivkeller commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

vercel Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.