GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Give the LLM client a request timeout so a hung provider can't stall the agent by uuzzrm · Pull Request #6 · nullcache/corecoder-ts Conversation
Contributor
Was running this against a flaky proxy the other day and hit something annoying: the agent would just sit there — no output, nothing. Turns out fetch() doesn't have a timeout. Node silently drops the timeout option if you pass it, so if a provider accepts the connection and then never answers, you're stuck until you hit Ctrl+C. So the LLM client now takes a timeoutMs (default 5 min, overridable with CORECODER_TIMEOUT_MS) and every request races against a timer. If the timer wins, it aborts the fetch and the retry loop treats it as a transient error and retries. Your own Ctrl+C still comes through as an AbortError — the timeout can't swallow it. Three tests cover it:
Writing the tests caught something fun: my fetch stub didn't reject when handed an already-aborted signal, so the second test hung forever. Real fetch rejects immediately in that case, so I fixed the stub, not the client. Design note: the timeout covers getting a response, not the streaming body — a model that's actively streaming can legitimately take a while, and that's Ctrl+C territory. Say the word if you'd rather have a whole-call timeout instead.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe manual merge of main mistyped the env parsing lines: ',' became '||' (dropping the fallback argument), temperature used intFromEnv instead of floatFromEnv, and one call was misspelled as pintFromEnv. Restore the intended calls, with timeoutMs also validated via intFromEnv.
nullcache
force-pushed
the
fix/llm-request-timeout
branch
from
c2f8d21 to
7bca881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |