GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BUG: Fix canonicalization/promotion of nested subarray types (#32761) by charris · Pull Request #32791 · numpy/numpy

Conversation

@charris

@charris charris commented Sep 25, 2026

Copy link
Copy Markdown
Member

Backport of #32761.

This pulls out the main subarray-from-tuple creation part from _convert_from_tuple and uses it for canonicalization/promotion with complicated (nested but not trivial) subarray types.

(Told AI to lift that code and the tests were originally written by it.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs labels Sep 25, 2026
@seberg @charris
BUG: Fix canonicalization/promotion of nested subarray types (numpy#3…
7561a96 
…2761)
@charris
charris force-pushed the backport-32761 branch from d68eb65 to 7561a96 Compare September 25, 2026 19:46
@charris

charris commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

The lint error is unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@charris
charris merged commit 298c8e5 into numpy:maintenance/2.5.x Sep 25, 2026
82 of 83 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@charris
charris deleted the backport-32761 branch September 25, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

00 - Bug 08 - Backport Used to tag backport PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@charris @seberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.