GeezerVison

Kusari Analysis Results:

✅ No Flagged Issues Detected
All values appear to be within acceptable risk parameters.

No pinned version dependency changes, code issues or exposed secrets detected!

@kusari-inspector rerun - Trigger a re-analysis of this PR
@kusari-inspector feedback [your message] - Send feedback to our AI and team
See Kusari's documentation for setup and configuration.
Commit: 5389038, performed at: 2025-09-12T14:29:19Z

Found this helpful? Give it a 👍 or 👎 reaction!

Would love to see this merged, good job!

@greptileai

Greptile Summary

This PR adds support for struct embedding in allOf compositions via the x-go-allof-embed-refs: true extension. The implementation allows referenced schemas to be embedded as structs rather than having their fields duplicated, enabling better code reuse for extendable types.

Key Changes:

• Added x-go-allof-embed-refs extension support in extension.go with a helper function to read the boolean value
• Modified schema merging logic in merge_schemas.go to conditionally generate embedded structs when the extension is enabled
• Added validation to prevent overlapping fields between sibling schemas and modifications to required fields outside their own schema when using embedding
• Added comprehensive test cases to verify the feature works correctly

Potential Issue:

• The test case in embed-openapi.yaml appears to have overlapping FirstName fields between PersonProperties and FirstName schemas in the Person allOf, which should trigger validation errors according to the implementation

Confidence Score: 3/5

• This PR adds a useful feature but has a test case that may not align with validation logic
• The core implementation is solid with proper error handling and validation checks. However, the test schema appears to have overlapping fields that should fail validation based on the implemented checks. This needs verification that either the test is correct or the validation logic needs adjustment.
• internal/test/all_of/embed-openapi.yaml needs verification - check if the overlapping FirstName field is intentional or if it should be removed from one of the schemas

_{Last reviewed commit: b109546}

This is a very tricky change, despite seeming simple, and I think we need lots more testing to ensure it doesn't break behavior.

When you embed structs, you also embed their methods.

In your example, say, WorkItem is a complex schema with a complex structure that requires implementing the json.Marshaler and json.Unmarshaler interfaces, which we do automatically.

Due to this embedding, when the json library is doing its unarshaling, it will find that WorkItemView has JSON marshaling specializations, and it will call those, so it will attempt to unmarshal WorkItemView using WorkItem.UnmarshalJSON.

I've hit these problems before.

Dynamic typing in a stricly typed language is quite hard, and allOf/anyOf/oneOf has been the most difficult thing to support in oapi-codegen.