GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Preserve union metadata when collapsing nullable wrappers by g-logunov · Pull Request #2566 · oapi-codegen/oapi-codegen

Conversation

@g-logunov

@g-logunov g-logunov commented Sep 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #2565.

Nested nullable unions lose their JSON methods and accessors during generation, causing JSON round trips to replace the payload with {}.

Preserve UnionElements and Discriminator in the shared collapseNullableUnion helper so generated types retain their JSON methods, union accessors, and discriminator helpers.

Regression coverage includes client/server round-trip matrix cases under schema-merging-behavior v1, v2, and v3, plus nullable-schema tests for nested anyOf/oneOf, null values, and discriminator accessors. The matrix cases fail against current main and pass with the fix.

Validation: make tidy, make generate, make test, and make lint passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@g-logunov
Preserve union metadata when collapsing nullable wrappers
e869693
@g-logunov
g-logunov force-pushed the feature/fix-nested-nullable-unions-upstream branch from 7c1bc35 to e869693 Compare September 27, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nested nullable unions silently discard JSON payloads

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@g-logunov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.