GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ci: check formatting with golangci-lint's gofmt formatter by eyoshioka · Pull Request #2602 · oapi-codegen/oapi-codegen

Conversation

@eyoshioka

@eyoshioka eyoshioka commented Oct 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #2409.

As proposed in my comment, this enables golangci-lint's gofmt formatter, so make lint, and therefore CI, fails on unformatted code. The enabled linters stay at golangci-lint's defaults.

  • The first commit runs gofmt -w on the 11 files that currently fail. Apart from an import order in pkg/codegen/utils.go, the changes are whitespace only.
  • The second commit adds .golangci.yml.

With the new config, make lint fails on the current main and passes with the first commit in every module. If you'd rather add the check to oapi-codegen/actions, I'll drop the second commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
eyoshioka and others added 2 commits October 8, 2026 14:44
@eyoshioka @claude
style: format Go files with gofmt
6a96130 
Generated with:

    git ls-files '*.go' | xargs gofmt -l | xargs gofmt -w

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@eyoshioka @claude
ci: check formatting with golangci-lint's gofmt formatter
e901660 
`make lint` runs golangci-lint, so enabling its gofmt formatter makes CI
fail on unformatted code. The linters stay at golangci-lint's defaults.

Closes oapi-codegen#2409

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@eyoshioka
eyoshioka marked this pull request as ready for review October 8, 2026 10:40
@eyoshioka
eyoshioka requested a review from a team as a code owner October 8, 2026 10:40
@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Adds code formatting configuration and reformats test files.

This PR appears safe to merge.

What we checked:

  • Local lint accepts version two: The root Makefile pins golangci-lint to v2.14.0 and passes that same binary to both child modules.

Summary

Adds gofmt checks through .golangci.yml and formats eleven existing Go files.

  • Keeps the default linters.
  • Preserves Go behavior and generated APIs.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "ci: check formatting with golangci-lint'..." · Reviewed by Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ci: run go fmt

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@eyoshioka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.