GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Name whole-file $ref union branches like inline ones by n-hiraha · Pull Request #2642 · oapi-codegen/oapi-codegen

Conversation

n-hiraha commented Oct 31, 2026

Copy link

Copy Markdown

Fixes #2639.

A oneOf/anyOf branch that $refs a whole file has a non-empty Ref but names no Go type (#308), so generateUnionElement skipped naming it and the accessors came out as AsStruct {...}(). Checking !IsGoTypeReference(element.Ref) instead names it after its path, like an inline branch. Diagnosis and fix are from @BogdanYarotsky.

Added internal/test/references/external/whole_file_union with the four forms from the issue (response body, mixed anyOf, component schema, property). It fails to generate without the fix. make generate doesn't change any existing generated code, and go test ./... passes in all three modules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Name whole-file $ref union branches like inline ones

541e578

A oneOf/anyOf branch that $refs a whole file names no Go type, so
generateUnionElement must name it after its path like an inline branch,
instead of using its inline struct as the accessor name.

Fixes oapi-codegen#2639.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A oneOf/anyOf branch that is a whole-file $ref generates Go that doesn't parse

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.