GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: keep every enum value when a deduplicated name collides with another by 56steve · Pull Request #2669 · oapi-codegen/oapi-codegen

Conversation

@56steve

@56steve 56steve commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

When two enum values sanitize to the same Go name, SanitizeEnumNames appends a numeric suffix. That suffix could land on a name another value already owns, and the map write silently replaced it. For example enum: [A, a, A1] produced only A and A1, so one value lost its constant (and [A, A1, a] lost A1's original mapping the same way).

The suffix loop now skips any name that another value claims or that is already taken, so the example yields A, A2 and A1. Enums without such a collision keep exactly the names they had before. The new test covers collisions with a later and an earlier value, plus the unchanged no-collision case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@56steve
fix: keep every enum value when a deduplicated name collides with ano…
e6bcae3
…ther
@56steve
56steve requested a review from a team as a code owner November 12, 2026 05:43
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

SanitizeEnumNames now reserves original names before assigning numeric suffixes.

  • Enum values keep separate Go names when suffixes collide.

Reviews (1) · Last reviewed commit: "fix: keep every enum value when a dedupl..." · Reviewed by Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@56steve
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.