GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix: keep every enum value when a deduplicated name collides with another by 56steve · Pull Request #2669 · oapi-codegen/oapi-codegen Conversation
Contributor
When two enum values sanitize to the same Go name, SanitizeEnumNames appends a numeric suffix. That suffix could land on a name another value already owns, and the map write silently replaced it. For example The suffix loop now skips any name that another value claims or that is already taken, so the example yields
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
[Medium impact] The PR appears safe to merge. Summary
Reviews (1) · Last reviewed commit: "fix: keep every enum value when a dedupl..." · Reviewed by Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.