GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add option for using bundled static hwloc by bratpiorka · Pull Request #1609 · oneapi-src/unified-memory-framework

Conversation

bratpiorka commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Add UMF_USE_BUNDLED_HWLOC option for using bundled static hwloc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bratpiorka force-pushed the rrudnick_static_hwloc branch 8 times, most recently from e6cfe87 to 757d81e Compare

September 24, 2026 08:05

bratpiorka requested a lite review from Copilot

September 24, 2026 13:14

Copilot started reviewing on behalf of bratpiorka

September 24, 2026 13:15

View session

Copilot AI reviewed

Sep 24, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical issues remain in static installation/linking and Windows bundled-header configuration.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3

Open (3)

Bundled hwloc archive missing from installed static UMF interface · New
Windows hwloc config omits HWLOC_WIN_SYS · New
Static hwloc config incorrectly applies __declspec(dllimport) · New

What changed in this PR

Adds UMF_USE_BUNDLED_HWLOC to use bundled static hwloc on Linux and Windows.

Changes:

Adds bundled hwloc headers and platform configurations.
Updates CMake integration, documentation, CI, and tooling exclusions.

File	Summary
`src/deps/hwloc/windows/include/hwloc/autogen/config.h`	Windows hwloc configuration.
`src/deps/hwloc/linux/include/hwloc/autogen/config.h`	Linux hwloc configuration.
`src/deps/hwloc/include/hwloc/shmem.h`	Bundled shared-memory topology API.
`src/deps/hwloc/include/hwloc/rsmi.h`	Bundled ROCm SMI API.
`src/deps/hwloc/include/hwloc/plugins.h`	Bundled plugin API.
`src/deps/hwloc/include/hwloc/openfabrics-verbs.h`	Bundled OpenFabrics API.
`src/deps/hwloc/include/hwloc/opencl.h`	Bundled OpenCL API.
`src/deps/hwloc/include/hwloc/nvml.h`	Bundled NVML API.
`src/deps/hwloc/include/hwloc/memattrs.h`	Bundled memory-attributes API.
`src/deps/hwloc/include/hwloc/linux.h`	Bundled Linux helpers.
`src/deps/hwloc/include/hwloc/linux-libnuma.h`	Bundled libnuma API.
`src/deps/hwloc/include/hwloc/levelzero.h`	Bundled Level Zero API.
`src/deps/hwloc/include/hwloc/inlines.h`	Bundled inline helpers.
`src/deps/hwloc/include/hwloc/glibc-sched.h`	Bundled glibc scheduling API.
`src/deps/hwloc/include/hwloc/gl.h`	Bundled OpenGL API.
`src/deps/hwloc/include/hwloc/export.h`	Bundled topology export API.
`src/deps/hwloc/include/hwloc/distances.h`	Bundled distances API.
`src/deps/hwloc/include/hwloc/diff.h`	Bundled topology-diff API.
`src/deps/hwloc/include/hwloc/deprecated.h`	Bundled compatibility API.
`src/deps/hwloc/include/hwloc/cudart.h`	Bundled CUDA runtime API.
`src/deps/hwloc/include/hwloc/cuda.h`	Bundled CUDA API.
`src/deps/hwloc/include/hwloc/cpukinds.h`	Bundled CPU-kind API.
`src/deps/hwloc/include/hwloc/bitmap.h`	Bundled bitmap API.
`scripts/check_license/file-exceptions.sh`	Excludes vendored files from license checks.
`README.md`	Documents the bundled hwloc option.
`CMakeLists.txt`	Configures bundled hwloc selection.
`.github/workflows/reusable_basic.yml`	Adds bundled hwloc CI coverage.
`.github/workflows/.spellcheck-conf.toml`	Excludes vendored files from spellchecking.
`.github/scripts/run-codespell.py`	Excludes vendored files from codespell checks.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

CMakeLists.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/deps/hwloc/windows/include/hwloc/autogen/config.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/deps/hwloc/windows/include/hwloc/autogen/config.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

bratpiorka force-pushed the rrudnick_static_hwloc branch from 757d81e to 0bbfa9d Compare

September 24, 2026 13:23

github-advanced-security Bot found potential problems

Sep 24, 2026

There was an error while loading. Please reload this page.

github-advanced-security Bot found potential problems

Sep 24, 2026

View reviewed changes

Comment thread

.github/workflows/reusable_basic.yml Fixed

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/workflows/reusable_basic.yml Fixed

Uh oh!

There was an error while loading. Please reload this page.

bratpiorka force-pushed the rrudnick_static_hwloc branch 4 times, most recently from 0a48623 to 4383652 Compare

September 29, 2026 12:57

bratpiorka requested a lite review from Copilot

September 29, 2026 13:09

Copilot started reviewing on behalf of bratpiorka

September 29, 2026 13:10

View session

Copilot AI reviewed

Sep 29, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Critical portability, CMake compatibility, symbol-isolation, and consumer-target issues remain unresolved.

Review effort: Lite
Findings: 4

Open (4)

Linux archive is incompatible with non-x86-64 targets · New
Use CMake 3.14-compatible install prefix expression · New
Windows bundled hwloc symbols conflict with user hwloc · New
Use exported umf::headers target · New

Resolved since last review (3)

Static hwloc config incorrectly applies __declspec(dllimport)
Windows hwloc config omits HWLOC_WIN_SYS
Bundled hwloc archive missing from installed static UMF interface

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

CMakeLists.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

src/CMakeLists.txt

		NAME)
		set(UMF_LIBS
		${UMF_LIBS}
		"$<INSTALL_INTERFACE:$<INSTALL_PREFIX>/${CMAKE_INSTALL_LIBDIR}/${UMF_HWLOC_ARCHIVE_NAME}>"

Comment thread

src/deps/hwloc/windows/include/hwloc/autogen/config.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/install_test/CMakeLists.txt

		find_package(umf REQUIRED CONFIG)

		add_executable(umf_install_consumer main.c)
		target_link_libraries(umf_install_consumer PRIVATE umf::umf umf::umf_headers)

bratpiorka force-pushed the rrudnick_static_hwloc branch 2 times, most recently from 9159115 to b03d490 Compare

September 29, 2026 15:41

github-advanced-security Bot found potential problems

Sep 29, 2026

View reviewed changes

Comment thread

.github/workflows/reusable_basic.yml

		- name: Build and install UMF
		run: \|
		cmake --build ${{env.BUILD_DIR}} --config ${{matrix.build_type}} -j $Env:NUMBER_OF_PROCESSORS
		cmake --install ${{env.BUILD_DIR}} --config ${{matrix.build_type}}

Comment thread

.github/workflows/reusable_basic.yml

		- name: Build and run test of installed UMF
		run: \|
		$extraArgs = @()
		$prefixPath = "${{env.INSTL_DIR}}"

bratpiorka force-pushed the rrudnick_static_hwloc branch 2 times, most recently from d4dc15d to 2aeb614 Compare

September 29, 2026 16:15

bratpiorka requested a lite review from Copilot

September 29, 2026 17:42

Copilot started reviewing on behalf of bratpiorka

September 29, 2026 17:42

View session

bratpiorka force-pushed the rrudnick_static_hwloc branch from 9d06f8a to 4b61f8a Compare

September 29, 2026 17:50

Copilot AI reviewed

Sep 29, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate build, linkage, compatibility, and artifact-generation issues remain.

Review effort: Lite
Findings: 4

Open (4)

Propagate platform libraries required by bundled hwloc archive · New
Fix Windows build script path for Visual Studio archive output · New
Use exported umf::headers target
Use CMake 3.14-compatible install prefix expression

Resolved since last review (2)

Windows bundled hwloc symbols conflict with user hwloc
Linux archive is incompatible with non-x86-64 targets

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

CMakeLists.txt

Comment on lines +322 to +325

		add_library(${UMF_HWLOC_NAME} INTERFACE)
		target_link_libraries(${UMF_HWLOC_NAME} INTERFACE "${LIBHWLOC_LIBRARIES}")
		target_include_directories(${UMF_HWLOC_NAME}
		INTERFACE ${LIBHWLOC_INCLUDE_DIRS})

Comment thread

src/deps/hwloc/windows/build_hwloc.ps1

		'-DCMAKE_STATIC_LINKER_FLAGS=/Brepro')
		Invoke-Native cmake @('--build', $BuildDir, '--config', 'Release', '--parallel')

		$lib = Join-Path $BuildDir 'Release\hwloc.lib'

bratpiorka force-pushed the rrudnick_static_hwloc branch 3 times, most recently from 5293fcc to e03ee0c Compare

October 8, 2026 06:27

bratpiorka added 6 commits

October 8, 2026 07:23


          Add hwloc headers and static libs


          Add CMake uption for using bundled hwloc

47a19d6


          Test bundled hwloc in CI

42e7846


          Exclude src/deps from code checks

63ef903


          Add test for UMF w static HWLOC

273ab1b

e03ee0c

bratpiorka requested a lite review from Copilot

October 8, 2026 08:09

Copilot started reviewing on behalf of bratpiorka

October 8, 2026 08:10

View session

Copilot AI reviewed

Oct 8, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two moderate compatibility and Windows installation-test issues remain unresolved.

5 open findings

Fix Windows build script path for Visual Studio archive output
Propagate platform libraries required by bundled hwloc archive
Use exported umf::headers target
Use CMake 3.14-compatible install prefix expression
Update Windows install check for bundled archive name · New

🧠 Review effort: Lite

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/test_installation.py

Comment on lines +110 to +113

		if self.hwloc and platform.system() == "Windows":
		lib.append(f"lib/{lib_prefix}hwloc.{lib_ext_static}")
		elif self.hwloc and not self.shared_library:
		lib.append(f"lib/{lib_prefix}umf_hwloc.{lib_ext_static}")

This branch has not been deployed

No deployments

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

+1 more reviewer

github-advanced-security[bot]

github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

bratpiorka commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bratpiorka commented Sep 23, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.