GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — allow setting `Onyx::SQL::Repository#db` with `DB::Transaction` instances by repomaa · Pull Request #107 · onyxframework/sql

Conversation

@repomaa

@repomaa repomaa commented Jul 24, 2019

Copy link
Copy Markdown

closes #97

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
acidtib reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vladfaust

vladfaust commented Jul 24, 2019

Copy link
Copy Markdown
Member

Hey, @repomaa, welcome back 😉

Would you mind adding some specs?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@repomaa
repomaa force-pushed the topic/transaction_assignment branch from c320430 to fe00e3a Compare July 24, 2019 21:45
@repomaa

repomaa commented Jul 24, 2019

Copy link
Copy Markdown
Author

Hey @vladfaust o/
I overlooked the db_spec dir. I hope the added specs are what you were roughly thinking of.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@repomaa
repomaa force-pushed the topic/transaction_assignment branch from fe00e3a to 7480f09 Compare July 24, 2019 21:49
vladfaust
vladfaust requested changes Jul 25, 2019
View reviewed changes
Comment thread db_spec/pg/repository/db_spec.cr Resolved

Uh oh!

There was an error while loading. Please reload this page.
@repomaa
repomaa force-pushed the topic/transaction_assignment branch from 7480f09 to 5b9e7d4 Compare July 25, 2019 11:31
@repomaa
allow setting Onyx::SQL::Repository#db with DB::Transaction insta…
0a154fd 
…nces
@repomaa
repomaa force-pushed the topic/transaction_assignment branch from 5b9e7d4 to 0a154fd Compare July 26, 2019 11:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfaust vladfaust vladfaust requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Repository#db=(DB::Transaction)

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@repomaa @vladfaust
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.