GeezerVison is showing github.com — Python: Fix grammar · oops4git/codeql@fb37330
File tree
Expand file treeCollapse file tree
Open diff view settings
python/tools/recorded-call-graph-metrics
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: python/tools/recorded-call-graph-metrics/README.md +2-2Lines changed: 2 additions & 2 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -4,7 +4,7 @@ also known as _call graph tracing_. |
4 | 4 |
|
5 | 5 | Execute a python program and for each call being made, record the call and callee. This allows us to compare call graph resolution from static analysis with actual data -- that is, can we statically determine the target of each actual call correctly. |
6 | 6 |
|
7 | | -Using the call graph tracer does incur heave toll on the performance. Expect 10x longer to execute program. |
| 7 | +Using the call graph tracer does incur a heavy toll on the performance. Expect 10x longer to execute the program. |
8 | 8 |
|
9 | 9 | Number of calls recorded vary a little from run to run. I have not been able to pinpoint why. |
10 | 10 |
|
@@ -25,7 +25,7 @@ $ head -n 100 projects/*/Metrics.txt |
25 | 25 |
|
26 | 26 | ### Expanding set of projects |
27 | 27 |
|
28 | | -It should be fairly straight forward to expand the set of projects. Most projects use `tox` for running their tests against multiple python versions. I didn't look into any kind of integration, but have manually picked out the instructions required to get going. |
| 28 | +It should be fairly straightforward to expand the set of projects. Most projects use `tox` for running their tests against multiple python versions. I didn't look into any kind of integration, but have manually picked out the instructions required to get going. |
29 | 29 |
|
30 | 30 | As an example, compare the [`tox.ini`](https://github.com/pallets/flask/blob/21c3df31de4bc2f838c945bd37d185210d9bab1a/tox.ini) file from flask with the configuration |
31 | 31 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: python/tools/recorded-call-graph-metrics/ql/lib/RecordedCalls.qll +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -179,7 +179,7 @@ class IdentifiedRecordedCall extends XMLRecordedCall { |
179 | 179 | // - all these calls were recorded |
180 | 180 | // |
181 | 181 | // without this `strictcount`, in the case `func(); func(); func()`, if 1 of the calls |
182 | | - // is not recorded, we woulld still mark the other two recorded calls as valid |
| 182 | + // is not recorded, we would still mark the other two recorded calls as valid |
183 | 183 | // (which is not following the rules above). + 1 to count `this` as well. |
184 | 184 | strictcount(this.getACall()) = strictcount(this.getOtherWithSameSetOfCalls()) + 1 and |
185 | 185 | forex(XMLRecordedCall rc | rc = this.getOtherWithSameSetOfCalls() | |
|
Collapse file
Copy file name to clipboardExpand all lines: python/tools/recorded-call-graph-metrics/ql/query/Metrics.ql +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
|
1 | 1 | import lib.RecordedCalls |
2 | 2 |
|
3 | | -// colum i is just used for sorting |
| 3 | +// column i is just used for sorting |
4 | 4 | from string text, float number, float ratio, int i |
5 | 5 | where |
6 | 6 | exists(int all_rcs | all_rcs = count(XMLRecordedCall rc) and ratio = number / all_rcs | |
|