GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Escape timestamp arrows in word-level subtitles by codewithfourtix · Pull Request #2847 · openai/whisper

Conversation

@codewithfourtix

@codewithfourtix codewithfourtix commented Sep 5, 2026

Copy link
Copy Markdown

Segment-level subtitles already replace --> in transcript text, but word-level subtitles leave it intact. Apply the same escaping before assembling word-level cues, including highlighted words.

Adds SRT and VTT regressions and checks that the input timings remain unchanged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Escape timestamp arrows in word-level subtitles
bc5de4d 
Signed-off-by: Ali Zulfiqar <[email protected]>
Copilot AI lite review requested due to automatic review settings September 5, 2026 17:22
Copilot started reviewing on behalf of codewithfourtix September 5, 2026 17:23
View session
Copilot AI reviewed Sep 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new regression test does not currently verify the “input timings remain unchanged” claim from the PR description, so the test coverage doesn’t fully match the stated acceptance criteria.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR ensures word-level subtitle output (SRT/VTT) escapes the --> timestamp arrow sequence inside subtitle text (word cues and highlighted-word cues), aligning behavior with existing segment-level subtitle escaping.

Changes:

  • Escape --> to -> in each word’s text before assembling word-level subtitle cues.
  • Add regression tests covering both SRT and VTT writers, with and without highlight_words.
File summaries
File Description
whisper/utils.py Escapes --> in word-level cue text before line splitting / cue assembly.
tests/test_subtitle_arrows.py Adds a regression test ensuring word-level subtitle text does not contain --> for both writers and highlight modes.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/test_subtitle_arrows.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@codewithfourtix
Address review feedback and strengthen regression coverage
779777e 
Signed-off-by: Ali Zulfiqar <[email protected]>
@sclfcz sclfcz mentioned this pull request Oct 7, 2026
fix: count display width so CJK subtitles respect max_line_width #2878
Open
@edawite edawite mentioned this pull request Oct 18, 2026
Escape literal transcript text in WebVTT subtitles #2890
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@codewithfourtix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.