GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Tokens rotation with additional headers - helper functions by wojteklembryk · Pull Request #854 · openid/AppAuth-iOS

Conversation

@wojteklembryk

@wojteklembryk wojteklembryk commented Apr 22, 2024

Copy link
Copy Markdown

Set of helpers to perform action with fresh tokens and additional headers in case of tokens rotation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

guilhermehmcarvalho and theDeniZ reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@wojciech-lembryk
Set of helpers to perform action with fresh tokens and additional hea…
9d960a2
…ders in case of tokens rotation
@ywsang

ywsang commented Apr 22, 2024

Copy link
Copy Markdown

Hi @wojteklembryk, thanks for the PR! Would you be able to provide us with some info about your use case for such helper functions?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wahabniazi56
wahabniazi56 approved these changes Aug 15, 2024
View reviewed changes

@wahabniazi56 wahabniazi56 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed very good addition, sometimes we need to pass headers in token requests. @mdmathias could you please merge into master?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@wahabniazi56 wahabniazi56 mentioned this pull request Aug 15, 2024
update custom header value and version kinde-oss/kinde-sdk-ios#20
Closed
2 tasks done
@DanielRivers

DanielRivers commented Aug 19, 2024

Copy link
Copy Markdown

@ywsang A use case here is Kinde uses a header value in the request to determine which SDK is making the request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@guilhermehmcarvalho

guilhermehmcarvalho commented Oct 4, 2024

Copy link
Copy Markdown

Hi @wojteklembryk, thanks for the PR! Would you be able to provide us with some info about your use case for such helper functions?

I can say that DPoP implementation is one such case.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@wojteklembryk

wojteklembryk commented Oct 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Hi everyone,
Apologies for the delayed response—I accidentally missed this thread.

@ywsang, there are several use cases that require passing additional headers during token rotation, such as:

  • DPoP, as mentioned by @guilhermehmcarvalho
  • Device fingerprinting
  • Bot protection
  • Passing additional metadata like the SDK version (as mentioned by @DanielRivers ) or device state
  • Tracing/observability

Overall, this PR does not introduce any new functionality; it simply exposes the changes introduced in #770 by @mdmathias.

Thanks for your suport and great work 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

guilhermehmcarvalho
guilhermehmcarvalho approved these changes Jan 21, 2026
View reviewed changes
@guilhermehmcarvalho

guilhermehmcarvalho commented Jan 21, 2026

Copy link
Copy Markdown

I'd like to bring back the discussion about this topic. It's a simple PR but crucial to some cases. We've been using a fork based on this branch for a long time now and it would be nice to have it merged so we can go back to using the main branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@guilhermehmcarvalho guilhermehmcarvalho guilhermehmcarvalho approved these changes
@wahabniazi56 wahabniazi56 wahabniazi56 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@wojteklembryk @ywsang @DanielRivers @guilhermehmcarvalho @wahabniazi56 @wojciech-lembryk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.