GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — PR to resolve retain cycle when AppAuth has a strong reference to PresentingViewController by Osama-Fawzi · Pull Request #919 · openid/AppAuth-iOS

Conversation

Osama-Fawzi commented Apr 18, 2025

Copy link

Copy Markdown

We have encountered many cases where there is a retain cycle due to the fact that AppAuth is initialized as a singleton and the login presenting ViewController is referenced strongly by AppAuth.

So, we have switched the reference to be weak so it can be broken when ViewController is dismissed to be deallocated.

also kExpiryTimeTolerance is differentiated between debug and release.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markusfassbender and beiglboe reacted with thumbs up emoji

All reactions

👍 2 reactions

Osama-Fawzi and others added 12 commits

November 29, 2023 20:14


          Update OIDExternalUserAgentIOS.m to weakify presentingViewController

a477d9a


          Update AppAuth.podspec

830d347


          Update AppAuth.podspec

10741e5


          Update OIDExternalUserAgentIOS.m

69b44a0


          Update OIDAuthState.m

2ee12ea


          Update OIDAuthState.m

bd5099c


          Update OIDAuthState.h

f330fc5


          Update OIDExternalUserAgentIOS.m

5c6e846


          Update OIDExternalUserAgentIOS.h

4e4a3a1


          Update OIDExternalUserAgentIOS.m

5793d7a


          cleaning up

ef9303c


          Merge remote-tracking branch 'upstream/master'

73411a7

Osama-Fawzi changed the title ~~PR to resolved retain cycle when AppAuth has a strong reference to PresentingViewController~~ PR to resolve retain cycle when AppAuth has a strong reference to PresentingViewController

Apr 18, 2025

Osama-Fawzi mentioned this pull request

Apr 18, 2025

Retain Cycle due to strong reference to PresentingViewController #920

Open

beiglboe commented Jun 24, 2026

Copy link

Copy Markdown

Would be nice to get this merged

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.