GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Fail the authorization flow instead of crashing when a code flow redirect has no code by Mohith26 · Pull Request #994 · openid/AppAuth-iOS ConversationFixes #813. A redirect for the This adds a check in Tests (in
Ran the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsA redirect for the code (or code id_token) response type without a code parameter was delivered as a successful OIDAuthorizationResponse with a nil authorizationCode. OIDAuthState's convenience flow then called tokenExchangeRequest, which raises kTokenExchangeRequestException and crashes the app. Validate the code in resumeExternalUserAgentFlowWithURL:error:, after the state check, and fail the flow with OIDErrorCodeOAuthAuthorizationClientError like the state validation does. Fixes openid#813.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Nocode query parameter in the redirect url throws exception
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |