GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Keep an author-written argument table even when later columns are not of one kind · Issue #158 · openjavaformat/open-java-format Open Labels enhancementNew feature or requestNew feature or request DescriptionUpstream: palantir#1783 palantir-java-format#1783 (closed unmerged on 2026-10-17) notes that the tabular-arguments heuristic keeps a grid of arguments only if column 0 is uniform and every other column has a majority of one expression kind. A values column mixing a sum, an identifier and a method call has no majority, so the grid collapses onto one line, while an almost identical call with uniform values keeps its table. The PR drops the check for columns after the first; column 0 and all row-length and start-column rules stay. The only existing golden that changes is the paired-arguments test. Why it matters to us: we have the same two checks in Affected files: Before (upstream behaviour before the change; our code has the same check, not run): assertThat("alpha", first + second, "bravo", someVariable, "charlie", compute(), "delta", other + thing); After (with the change, input written as a grid): assertThat( "alpha", first + second, "bravo", someVariable, "charlie", compute(), "delta", other + thing); Suggested action: adopt-the-idea if we want consistent table handling; low priority. Filed from an upstream-watch ticket after manual review. ActivityMetadataMetadataAssigneesLabelsenhancementNew feature or requestNew feature or request TypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |