GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Keep an author-written argument table even when later columns are not of one kind · Issue #158 · openjavaformat/open-java-format

Keep an author-written argument table even when later columns are not of one kind #158

New issue
Copy link
New issue
Copy link
Open
Open
Keep an author-written argument table even when later columns are not of one kind#158
Copy link
Labels
enhancementNew feature or requestNew feature or request

Description

@abashev
abashev
opened on Oct 25, 2026
Issue body actions

Upstream: palantir#1783
Kind: idea | Priority: low

palantir-java-format#1783 (closed unmerged on 2026-10-17) notes that the tabular-arguments heuristic keeps a grid of arguments only if column 0 is uniform and every other column has a majority of one expression kind. A values column mixing a sum, an identifier and a method call has no majority, so the grid collapses onto one line, while an almost identical call with uniform values keeps its table. The PR drops the check for columns after the first; column 0 and all row-length and start-column rules stay. The only existing golden that changes is the paired-arguments test.

Why it matters to us: we have the same two checks in argumentsAreTabular (around lines 3366-3370 of JavaInputAstVisitor), so identical inputs give inconsistent results today. It only ever keeps a table the author already wrote, so risk is low, but it changes an existing golden file and diverges from palantir.

Affected files: open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java, the PairedArguments test data.

Before (upstream behaviour before the change; our code has the same check, not run):

assertThat("alpha", first + second, "bravo", someVariable, "charlie", compute(), "delta", other + thing);

After (with the change, input written as a grid):

assertThat(
        "alpha", first + second,
        "bravo", someVariable,
        "charlie", compute(),
        "delta", other + thing);

Suggested action: adopt-the-idea if we want consistent table handling; low priority.


Filed from an upstream-watch ticket after manual review.

Activity

  1. abashev
    added
    enhancementNew feature or requestNew feature or request
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402520 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.