GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Format MOE strip markers in javadoc like any other HTML comment by abashev · Pull Request #155 · openjavaformat/open-java-format Conversation
Collaborator
google/MOE, the tool whose What changes for a javadoc that still carries the markers:
Before, for the footer tags of the test: * @param user the person to teleport. * <!-- MOE:begin_intracomment_strip --> * Users must sign go/deatomize-waiver ahead of time. * <!-- MOE:end_intracomment_strip --> * <!-- MOE:begin_intracomment_strip --> * @deprecated Sometimes turns the user into a goat. * <!-- MOE:end_intracomment_strip --> After: * @param user the person to teleport. * <!-- MOE:begin_intracomment_strip --> * Users must sign go/deatomize-waiver ahead of time. * <!-- MOE:end_intracomment_strip --> * <!-- MOE:begin_intracomment_strip --> * @deprecated Sometimes turns the user into a goat. * <!-- MOE:end_intracomment_strip --> TestsWritten first: Verification
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsgoogle/MOE, the tool whose intracomment-strip markers the javadoc formatter recognised, has been dead for years. The lexer no longer gives `<!-- MOE:begin_intracomment_strip -->` and `<!-- MOE:end_intracomment_strip -->` token types of their own, and the writer loses the state that queued the begin marker until the next token and remembered its indent for the end marker: both markers now take the HTML comment path, a line of their own at the indent of the text around them. The layouts the old test pinned change in two places: a blank line the next tag asks for comes after the begin marker instead of before it, and a marker inside or between footer tags is indented as a continuation line of the tag it follows. A begin marker that closes the comment without an end marker is kept instead of silently deleted. The test was written first: moeStripMarkersAreOrdinaryHtmlComments failed before the change; the three cases that only guarded the begin/end pairing against exploding are gone. None of the 15,747 JDK 21 sources changes with javadoc formatting on; the JDK carries no MOE markers. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |