GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Expect a joined detail message in commentAfterOpeningDelimiter-assert by abashev · Pull Request #178 · openjavaformat/open-java-format

Conversation

@abashev

@abashev abashev commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

What

commentAfterOpeningDelimiter-assert.case came with #175. Its last assert ends in the detail message "x below " + "y": two string literals on one line with no comment between them. #176 joins such literals, so the formatter now writes "x below y", and since both were merged every build job of 21.X.X fails on that case (run 41197372203). Each PR had passed on its own: the head of #176 did not contain #175.

The fix

The expected output now has the joined literal, as #176 did for the cases of NON-NLS and palantir-10. The input keeps the two literals.

Tests

On JDK 21, ./gradlew test --rerun is green: FormatterCasesTest 915 cases, 1482 tests in all modules, 14 skipped.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abashev
Expect a joined detail message in commentAfterOpeningDelimiter-assert
957be3e 
The case came with #175 and ends in the detail message "x below " +
"y": two string literals on one line with no comment between them.
#176 joins such literals, so the formatter now writes "x below y", and
since both were merged every build job of 21.X.X fails on that line.
Each had passed on its own, because #176 was tested without the case.

The expected output now has the joined literal, as #176 did for the
cases of NON-NLS and palantir-10; the input keeps the two literals.

Tests on JDK 21: FormatterCasesTest 915 cases, 1482 tests in all
modules, none failing.
@abashev
abashev merged commit 336a286 into 21.X.X Oct 31, 2026
17 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@abashev
abashev deleted the fix/assert-case-joined-literals branch October 31, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@abashev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.