GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added initial zimwriterfs clone by rgaudin · Pull Request #165 · openzim/python-scraperlib

Conversation

@rgaudin

@rgaudin rgaudin commented May 27, 2024

Copy link
Copy Markdown
Member

Here's a first shot at an implementation of zimwriterfs using scraperlib.

It uses the same interface except for two missing features:

  • --inflateHtml: now sure it's useful at all
  • --skip-libmagic-check: didn't seem worth the effort for a first version

Very little code here, it's mostly CLI. I did not use make_zim_file() so we can set those creator options that zimwriterfs allows to set…

WARN: dumping this so it's not lost but not sure it's ready (haven't written any test yet)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rgaudin
Added initial zimwriterfs clone
a288082
@rgaudin
rgaudin requested a review from benoit74 May 27, 2024 14:05
@rgaudin rgaudin self-assigned this May 27, 2024
@codecov

codecov Bot commented May 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d49831) to head (a288082).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1393      1393           
  Branches       240       240           
=========================================
  Hits          1393      1393

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benoit74
benoit74 reviewed May 28, 2024
View reviewed changes

@benoit74 benoit74 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing much to add, aside from the fact that I don't know if we want to merge this now since you mentioned it is not sufficiently tested.

That been said, it is quite "external", so I don't mind much if we merge this now and add tests later on. It is not included in coverage report anyway ^^

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rgaudin

rgaudin commented May 28, 2024

Copy link
Copy Markdown
Member Author

There is no real need for this so it can await its tests ; I'd love to complete (or someone else) the missing features and add a workflow that builds an independent static binary as well (just to annoy @kelson42!)

@kelson42 what is the purpose of the --inflateHtml feature?

The way I understand it is that when adding files, all files which extension is considered HTML are decompressed as if those would be zip(zlib)-encoded in-place and if that fails, the raw content is added instead.

I'm curious to know what scenario lead to this ugly thing 🙃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benoit74
benoit74 marked this pull request as draft July 24, 2026 09:34

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoit74 benoit74 benoit74 left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rgaudin rgaudin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rgaudin @benoit74
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.