GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: exclude samples from Maven Central publishing by csviri · Pull Request #3537 · operator-framework/java-operator-sdk

Conversation

@csviri

@csviri csviri commented Aug 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The Kotlin module has no Java sources, so maven-javadoc-plugin attaches no
javadoc jar to it and Central rejects the whole deployment with
"Javadocs must be provided but not found in entries", which is what
broke the 5.5.1 release. It only exists as a Kotlin interop E2E test,
so keep it out of the published bundle.

But exlcuding all the e2e tests since those does not make sense to publish.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Copilot AI lite review requested due to automatic review settings August 5, 2026 18:08
@openshift-ci
openshift-ci Bot requested review from metacosm and xstefank August 5, 2026 18:08
Copilot started reviewing on behalf of csviri August 5, 2026 18:09
View session
Copilot AI reviewed Aug 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The added skipPublishing property is not consumed by the current release/publishing configuration in this repo, so the module may still be included in the Central publishing bundle.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR aims to prevent Maven Central publishing failures by excluding the Kotlin sample operator module from release publishing, since it doesn’t produce a Javadoc JAR and Central rejects the deployment.

Changes:

  • Adds a skipPublishing property to sample-operators/kotlin-operator intended to prevent publishing of that module.
File summaries
File Description
sample-operators/kotlin-operator/pom.xml Adds a property intended to skip publishing this module to avoid Central deployment rejection.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread sample-operators/kotlin-operator/pom.xml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@csviri
fix: exclude the Kotlin sample from Maven Central publishing
c90a1e3 
The module has no Java sources, so maven-javadoc-plugin attaches no
javadoc jar to it and Central rejects the whole deployment with
"Javadocs must be provided but not found in entries", which is what
broke the 5.5.1 release. It only exists as a Kotlin interop E2E test,
so keep it out of the published bundle.
@csviri
csviri force-pushed the release-fix-kotlin branch from 47f1844 to c90a1e3 Compare August 5, 2026 18:18
metacosm
metacosm requested changes Aug 5, 2026
View reviewed changes
Comment thread sample-operators/kotlin-operator/pom.xml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@csviri
fix: exclude all samples from Maven Central publishing
98e35e7 
Replaces the skipPublishing property on the Kotlin sample with an
excludeArtifacts list on central-publishing-maven-plugin, so the
exclusion lives next to the publishing configuration, and extends it to
every sample module: they are demos and end-to-end tests, not artifacts
to depend on.
Copilot AI review requested due to automatic review settings August 5, 2026 18:27
@csviri csviri changed the title fix: exclude the Kotlin sample from Maven Central publishing fix: exclude samples from Maven Central publishing Aug 5, 2026
@csviri
csviri requested a review from metacosm August 5, 2026 18:28
Copilot started reviewing on behalf of csviri August 5, 2026 18:28
View session
Copilot AI approved these changes Aug 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The change is narrowly scoped to release publishing configuration and directly addresses the described Central deployment failure without impacting runtime code.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
metacosm
metacosm approved these changes Aug 5, 2026
View reviewed changes
@csviri
csviri merged commit 87248d7 into main Aug 5, 2026
52 of 53 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@csviri
csviri deleted the release-fix-kotlin branch August 5, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metacosm metacosm metacosm approved these changes
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot approved these changes
@xstefank xstefank Awaiting requested review from xstefank

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@csviri @metacosm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.