GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — 🌱 OPRUN-4849: Enable standalone ClusterObjectSet E2E scenarios by fao89 · Pull Request #3161 · operator-framework/operator-controller

Conversation

fao89 commented Nov 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Description

Select direct ClusterObjectSet scenarios with @ObjectController and
@ClusterObjectSet, and use object-controller readiness without requiring
operator-controller or catalogd.

Keep the revision-pruning integration scenario behind @BoxcutterRuntime and
move its OLM and registry prerequisites into that scenario. This allows direct
COS coverage to run against a standalone object-controller installation while
preserving ClusterExtension integration coverage.

This is the second PR in the OPRUN-4849 stack, following merged PR #3158.
Later branches enable standalone COD scenarios and add COS lifecycle coverage.

Jira: https://redhat.atlassian.net/browse/OPRUN-4849

Validation:

COS branch: 56 E2E helper tests passed with the race detector.
All E2E suites compile, and object-controller step registration succeeds.
Rebased combined stack: make verify, make lint (0 issues), and
make test-unit passed using Go 1.26.5.
Standalone COS live run: 31 scenarios / 216 steps passed, with no skipped or
undefined steps, against object-controller without operator-controller or
catalogd.
The complete branch diff against main contains 6 files.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

Summary by CodeRabbit

Tests
- Updated end-to-end scenarios to check object-controller availability and use more specific test tags.
- Adjusted setup for selected scenarios to include the services they require.
- Collision, adoption, preflight, validation, and revision scenarios remain covered.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          test(e2e): enable standalone ClusterObjectSet scenarios

cf29926

Select direct COS scenarios with ObjectController and ClusterObjectSet
tags and require only object-controller in their shared prerequisites.
Keep ClusterExtension integration coverage behind BoxcutterRuntime.

Move registry setup into the group pruning integration scenario so direct
COS scenarios can run without catalogd or operator-controller.

Refs: OPRUN-4849
Signed-off-by: Fabricio Aguiar <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

netlify Bot commented Nov 12, 2026

Copy link

Copy Markdown

👷 Deploy request for olmv1 pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`cf29926`

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

openshift-ci Bot requested review from fgiudici and grokspawn

November 12, 2026 13:04

coderabbitai Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

End-to-end feature tags and setup steps now distinguish ObjectController scenarios from the revision-pruning scenario, which retains OLM and image-registry setup.

Changes: ObjectController end-to-end tests

Layer / File(s)	Summary
Update feature tags and prerequisites `test/e2e/object-controller/features/cos_object_collision_and_adoption.feature`, `test/e2e/object-controller/features/cos_preflight.feature`, `test/e2e/object-controller/features/cos_revision_identity.feature`, `test/e2e/object-controller/features/cos_static_validation.feature`, `test/e2e/object-controller/features/revision.feature`	These features use ObjectController tags. Background setup checks for object-controller availability where changed.
Scope setup to group scenarios `test/e2e/object-controller/features/group.feature`	The feature-level Boxcutter tag is removed. ObjectController tags are added to selected scenarios, and OLM and image-registry setup moves to revision pruning.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: perdasilva, fgiudici, dtfranz

Merge Risk: Minimal · up to cf299

This PR changes only E2E test tags and setup steps so that direct ClusterObjectSet scenarios can run against object-controller alone. No production code changes, and no concrete merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "🌱 OPRUN-4849: Enable standalone ClusterObjectSet E2E scenarios" matches the main change. The diff retags the direct ClusterObjectSet feature files from BoxcutterRuntime to ObjectController …
Description check		The description follows the repository template. It has a Description section that explains the change and its motivation: direct COS scenarios run against standalone object-controller, and the revisi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "🌱 OPRUN-4849: Enable standalone ClusterObjectSet E2E scenarios" matches the main change. The diff retags the direct ClusterObjectSet feature files from BoxcutterRuntime to ObjectController and ClusterObjectSet, and switches their background readiness from OLM to object-controller. The title uses the correct seedling prefix for an 'other' change and names the Jira key.

Full details: Description check

Explanation

The description follows the repository template. It has a Description section that explains the change and its motivation: direct COS scenarios run against standalone object-controller, and the revision-pruning scenario stays behind BoxcutterRuntime with its OLM and registry prerequisites moved into it. It also lists validation steps and the Jira link. The Reviewer Checklist is present with items checked. The API Go Documentation item is unchecked, which fits a change that alters no exported declarations.

Finishing Touches

Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

Source mode: Auto

Repository: Unavailable

Branch: Unavailable

File: No configuration file from this repository applied

Commit: Unavailable

Layers: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: `86e06c2d-7ac6-4dc4-a090-e7e6ed79ae67`

Commits

Reviewing files that changed from the base of the PR and between `2534523` and `cf29926`.

Files selected for processing: 6

`test/e2e/object-controller/features/cos_object_collision_and_adoption.feature`

`test/e2e/object-controller/features/cos_preflight.feature`

`test/e2e/object-controller/features/cos_revision_identity.feature`

`test/e2e/object-controller/features/cos_static_validation.feature`

`test/e2e/object-controller/features/group.feature`

`test/e2e/object-controller/features/revision.feature`

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fao89 mentioned this pull request

Nov 12, 2026

🌱 OPRUN-4849: Enable standalone ClusterObjectDeployment E2E scenarios #3162

Merged

3 of 4 tasks

perdasilva commented Nov 12, 2026

Copy link

Copy Markdown

Contributor

/approve

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

openshift-ci Bot commented Nov 12, 2026

Copy link

Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label

Nov 12, 2026

fgiudici reviewed

Nov 12, 2026

View reviewed changes

fgiudici left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

openshift-ci Bot assigned fgiudici

Nov 12, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label

Nov 12, 2026

openshift-merge-bot Bot merged commit ec3a2f6 into operator-framework:main

Nov 12, 2026

31 checks passed

Uh oh!

There was an error while loading. Please reload this page.

fao89 mentioned this pull request

Nov 12, 2026

🌱 OPRUN-4849: Cover standalone ClusterObjectSet object lifecycle #3168

Open

3 of 4 tasks

Reviewers

fgiudici

fgiudici left review comments

grokspawn

Awaiting requested review from grokspawn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

fgiudici

Labels

approved

Indicates a PR has been approved by an approver from all required OWNERS files.

lgtm

Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

fao89 commented Nov 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer Checklist

Summary by CodeRabbit

Uh oh!

netlify Bot commented Nov 12, 2026

👷 Deploy request for olmv1 pending review.

Uh oh!

coderabbitai Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Nov 12, 2026

Uh oh!

openshift-ci Bot commented Nov 12, 2026

Uh oh!

fgiudici left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fao89 commented Nov 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.