GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add rudimentary support for _tkinter in GraalPy by phkeese · Pull Request #381 · oracle/graalpython

Conversation

@phkeese

@phkeese phkeese commented Feb 9, 2024

Copy link
Copy Markdown

This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter. Before use, the bindings need to be built using tklib_build.py. The code was modified from existing code in PyPy's main branch.

Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons. It seems like there is a bug in the cffi module causing a SegFault. macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled. Windows was not tested.

Tests
Running CPython's tests for tkinter and ttk shows some success, but some tests still fail, raise an error or even crash with a segmentation fault:
image
image

The main culprit for the failing tests seem to be Unicode errors, PyPy's 3.8 branch seems to fix those.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@phkeese @Margarete01 @timfel
Add rudimentary support for _tkinter in GraalPy
cd60e90 
This commit adds the _tkinter module to the list of built-in modules to allow use of tkinter.
Before use, the bindings need to be built using tklib_build.py.
The code was modified from existing code in PyPy's main branch.

Right now, opening a window under Linux works, but still crashes on interacting with UI elements such as buttons.
It seems like there is a bug in the `cffi` module causing a SegFault.
macOS complains about other threads accessing the main window and the build script has some trouble finding the correct library for Tcl and Tk, as macOS comes with an older version preinstalled.
Windows was not tested.

Co-authored-by: Margarete Dippel <[email protected]>
Co-authored-by: Tim Felgentreff <[email protected]>
@oracle-contributor-agreement

oracle-contributor-agreement Bot commented Feb 9, 2024

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: phkeese
  • [email protected] (@phkeese)
  • [email protected]

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Feb 9, 2024

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@phkeese
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.