GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Alter when accessor methods are generated. by JakeWharton · Pull Request #84 · luontola/retrolambda

Conversation

@JakeWharton

@JakeWharton JakeWharton commented Jan 11, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs #81 item 1. This removes 561 methods from our app.

Closes #89.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mattprecious, serj-lotutovici, yshrsmz, jeremy-techson, yukuku, desmond1121, and Dwite reacted with thumbs up emoji charlag reacted with heart emoji
All reactions
  • 👍 7 reactions
  • ❤️ 1 reaction
@JakeWharton JakeWharton mentioned this pull request Jan 11, 2016
Optimize generated code to reduce method count. #81
Closed
JakeWharton
JakeWharton reviewed Jan 11, 2016
View reviewed changes
Comment thread retrolambda/src/main/java/net/orfjackal/retrolambda/interfaces/ClassAnalyzer.java

@JakeWharton JakeWharton Jan 11, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the static methods is the mechanism through which I'm going to implement point 2 on #81. By having a list of the private static methods which are synthetic and looking at invokedynamic's to those methods we can remove the private bit on the static method and skip the accessor.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JakeWharton
JakeWharton force-pushed the jw/no-accessor-for-visible-methods branch from d6985da to c06dc84 Compare April 27, 2016 14:08
@JakeWharton JakeWharton changed the title Do not generate accessor method for non-private methods. Alter when accessor methods are generated. Apr 27, 2016
@JakeWharton

JakeWharton commented Apr 27, 2016

Copy link
Copy Markdown
Contributor Author

I have updated this to address #89 as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JakeWharton
JakeWharton force-pushed the jw/no-accessor-for-visible-methods branch from c06dc84 to fb6101a Compare April 27, 2016 14:27
@JakeWharton
Alter when accessor methods are generated.
52364bc 
For owned, non-private methods, omit the accessor since the generated class can access the method directly. For non-owned methods, generate the accessor when the method is protected since the generated class will not have access.
@JakeWharton
JakeWharton force-pushed the jw/no-accessor-for-visible-methods branch from fb6101a to 52364bc Compare April 28, 2016 02:59
@luontola
luontola merged commit 52364bc into luontola:master Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JakeWharton @luontola
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.